Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for zype extractor #23

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Conversation

lyarenei
Copy link
Contributor

@lyarenei lyarenei commented Dec 17, 2022

Add a configuration for Zype extractor. This one is used by Nebula and possibly by some other platforms, but I'm not aware of any.

A sample JSON for reference, if you want to check: https://pastebin.com/cuxZpa9C
That one is then converted to this nfo: https://pastebin.com/P0iAsiNJ

I'm not sure about the description, as it can get pretty bloated as you can see. While that itself is not a problem, I guess not many clients wouldn't do correct parsing to show it correctly (Jellyfin doesn't unfortunately). In my current setup, I just remove it.

@lyarenei
Copy link
Contributor Author

lyarenei commented Dec 17, 2022

Also, I think that these configurations are not needed, unless I'm overlooking something. As the json output should be always the same (it'd be the job of the extractor to properly fill the data). Unless the extractors are allowed to write custom stuff into the json file.

@owdevel
Copy link
Owner

owdevel commented Sep 3, 2023

Thanks for contributing!

You are correct that the json output should be similar, the point of the custom extractors is to allow for custom stuff to be added to json files as not some properties may or may not be implemented by certain extractors.

I'm in the process of revisiting this project and changing the flow to work better. Thank you for your interest!

@owdevel owdevel merged commit 5099bc4 into owdevel:dev Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants