Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Typo Fix on The Contribution Page #29

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Vizonex
Copy link
Contributor

@Vizonex Vizonex commented Jan 22, 2025

Found a typo in your project under the Contribution page and want to fix it while I try to learn what exactly it is and does and how I can help make it better overall.

@owenlamont
Copy link
Owner

Thanks so much for being my first contributor!

Looks like you've also uncovered an issue with my CI... I try to auto-comment PRs with test coverage but it looks like that doesn't work on PRs I didn't create 🤔 I'll have to investigate what I can do about that.

@owenlamont owenlamont merged commit 8643017 into owenlamont:main Jan 22, 2025
16 of 17 checks passed
@owenlamont
Copy link
Owner

Just merged this #30 which hopefully resolves that CI issue. Wish I could have my test coverage comment on fork repos PRs but apparently there's no way to achieve that without giving dangerous workflow permissions - so just printing the coverage inside the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants