merge up to latest leeds master #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than 10 minutes, which is longer than the multi threaded section before it. changing to call data.table::rbindlist reduces this to 20 seconds or so. In order for this to work the columns need to stay in the same order - which we achieve by flipping the join round so that the target is on the left hand side of the output instead of the right hand side - which means that the columns stay in the same order, so we don't need to match on names either.
- longer than the subsequent multi-threaded section. Replacing with a transpose of the dataframe reduces this to 3s or so. The transpose causes the named dataframe to be coerced into a unnamed vector of int, so we have to index into the vector by number, and convert the date coerced into int back into a date.
Oo tfwm performance
make console message clearer about what action is being carried out
…ave a NA route_type, so when loading into most GTFS databases violate non-null constraint on route_type column. While they are a valid timetabled train (mostly freight), we're not interested in them if we're doing passenger service timetabling.
…stence of agency records and rest of data.
Performance + Verbosity of validation + thoroughness of fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.