Let VersionTracker optionally ignore archive steps #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloarosado
changed the title
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
StepUpdater, the propertysteps_dfshould only contain active steps (since they are the only ones to be considered for update, and the only ones relevant for the ETL dashboard). Indeed, columnstepofsteps_df(which is the main index) only contains active seps. However, other columns (e.g.direct_usages) do contain archive steps. This issue was mentioned in #2365This raises an
IndexErrorin the ETL dashboard, if, in the Operations list, you click on "Add direct usages" for steps that are used by archive steps.This PR fixes that. Now
VersionTracker(which is loaded byStepUpdater) can be initialized with the argumentignore_archive=True.