Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix anomalist bugs #3427

Merged
merged 3 commits into from
Oct 18, 2024
Merged

🐛 Fix anomalist bugs #3427

merged 3 commits into from
Oct 18, 2024

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Oct 17, 2024 •
edited
Loading

  • Normalize gp_outlier to (0, 1)
  • Let detectors own anomaly text instead of having it in the app
  • Fix a couple of bugs I found during testing

@Marigold Marigold marked this pull request as ready for review October 17, 2024 19:58
@Marigold Marigold requested a review from pabloarosado October 17, 2024 19:58
@owidbot
Copy link
Contributor

owidbot commented Oct 17, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-fix-anomalist-bugs

chart-diff: ✅ No charts for review.

Edited: 2024-10-17 20:00:06 UTC
Execution time: 3.84 seconds

pabloarosado
pabloarosado approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good!

@Marigold Marigold merged commit 9e1caac into wizard-anomalist Oct 18, 2024
3 of 7 checks passed
@Marigold Marigold deleted the fix-anomalist-bugs branch October 18, 2024 08:33
@lucasrodes lucasrodes mentioned this pull request Nov 4, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloarosado pabloarosado pabloarosado approved these changes

Assignees

@Marigold Marigold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marigold @owidbot @pabloarosado