Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Persist filter values in the URL for Anomalist #3441

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

Marigold
Copy link
Collaborator

  • Persist selected datasets and filter values in the URL
  • Display anomalies from DB at startup (don't wait for a click on "Detect anomalies")
  • A couple of small performance optimizations

@owidbot
Copy link
Contributor

owidbot commented Oct 21, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-persist-filter-values

chart-diff: ✅ No charts for review.

Edited: 2024-10-21 10:10:06 UTC
Execution time: 3.87 seconds

Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! On one of your comments: Yes, I think it doesn't make sense anymore to detect new datasets based on file changes. Since anomaly detection now runs automatically, we can simply list new datasets as any dataset for which there are anomalies detected.
That said, it would be good if the user could know that anomaly detection is currently running (especially if the results they are seeing are incomplete).

@Marigold Marigold merged commit f0c131c into wizard-anomalist Oct 21, 2024
7 of 8 checks passed
@Marigold Marigold deleted the persist-filter-values branch October 21, 2024 13:10
@lucasrodes lucasrodes mentioned this pull request Nov 4, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants