🔨 Refactor mdims #3945
Merged
🔨 Refactor mdims #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ No differences foundLegend: +New ~Modified -Removed =Identical Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippetAutomatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2025-02-14 09:42:52 UTC |
|
Thanks for looking into this. Couple of things:
|
lucasrodes
added a commit
that referenced
this pull request
Feb 10, 2025
* Update multidim-schema.json * Restore definitions * support display setting in upsert check, add other dimensions than y * format * integrate changes proposed in #3945 * integrate changes proposed in #3945 (pt 2) * format * wip * add comments, remove deprecate code * minor typo --------- Co-authored-by: lucasrodes <lucasrodes@users.noreply.github.com>
lucasrodes
added a commit
that referenced
this pull request
Feb 14, 2025
* 📊 covid: mdims * snapshot * clean * add schema * wip * improve description * ✨ covid mdims maintenance * remove titleVariant * 📊 Update origin URL for COVID cases data * Test update of covid.cases.yml * Update multidim-schema.json * Restore definitions * 📊 work on covid mdims * wip * wip * support display setting in upsert check, add other dimensions than y * format * add descriptions * rollback * interval -> period * fix publication date * fix publication date * interval -> period * fix publication date * fix year type * undo debug change in topic url * integrate changes proposed in #3945 * integrate changes proposed in #3945 (pt 2) * format * wip * add comments, remove deprecate code * fix * wip * roll-back * add missing descriptions * 🎉 Let export steps execute implicit grapher://grapher steps * wip * Let export steps execute implicit grapher://grapher steps * Hide causes of death mdim, which is causing issues * Improve format * suggestions by Ed * fix missing description * cases/deaths metadata * use data steps * hospital mdim * fix date publication * custom changes to boosters MDIM * Reference only a subset of the grapher schema Also, none of the properties are requiered. * adapt vaccinations * wip * xm * fix _expand for new API * wip models * support expand path for dict-defined indicators * adding support for all dimensions * infections model * format * format * covax * 🔨 Refactor indicator path handling in multidimensional config * 📊 Update COVAX configuration with sorting options and improved titles * style * covax mdim * set value in df with .loc * update xm URLs * wip: xm models mdim * look for table-to-uri mapping also in private steps * add help text * 📊 Remove xm_who data reference from COVID DAG * undo commented dependencies * fix minor metadata typo * add more help texts to MDIMs dropdown options * typo * add description * cases_tests * add missing dependency regions * fix map brackets * add description key in vax by manuf * add description key to testing * fix map bracket sin xm * remove unnecessary schema reference * wip vax breakdown * wip * wip * wip * change function, deprecate it * wip: expand_views * wip: automate view generation * wip * MDIM config auto-generate improvements * automate mobility covid MDIM * MDIM on vax breakdown can't really be used atm --------- Co-authored-by: Martin Račák <rakyi@users.noreply.github.com> Co-authored-by: Martin Račák <martin.racak@ourworldindata.org> Co-authored-by: Pablo Rosado <pabloarosado@gmail.com>
lucasrodes
added a commit
that referenced
this pull request
Feb 14, 2025
* 📊 covid: mdims * snapshot * clean * add schema * wip * improve description * ✨ covid mdims maintenance * remove titleVariant * 📊 Update origin URL for COVID cases data * Test update of covid.cases.yml * Update multidim-schema.json * Restore definitions * 📊 work on covid mdims * wip * wip * support display setting in upsert check, add other dimensions than y * format * add descriptions * rollback * interval -> period * fix publication date * fix publication date * interval -> period * fix publication date * fix year type * undo debug change in topic url * integrate changes proposed in #3945 * integrate changes proposed in #3945 (pt 2) * format * wip * add comments, remove deprecate code * fix * wip * roll-back * add missing descriptions * 🎉 Let export steps execute implicit grapher://grapher steps * wip * Let export steps execute implicit grapher://grapher steps * Hide causes of death mdim, which is causing issues * Improve format * suggestions by Ed * fix missing description * cases/deaths metadata * use data steps * hospital mdim * fix date publication * custom changes to boosters MDIM * Reference only a subset of the grapher schema Also, none of the properties are requiered. * adapt vaccinations * wip * xm * fix _expand for new API * wip models * support expand path for dict-defined indicators * adding support for all dimensions * infections model * format * format * covax * 🔨 Refactor indicator path handling in multidimensional config * 📊 Update COVAX configuration with sorting options and improved titles * style * covax mdim * set value in df with .loc * update xm URLs * wip: xm models mdim * look for table-to-uri mapping also in private steps * add help text * 📊 Remove xm_who data reference from COVID DAG * undo commented dependencies * fix minor metadata typo * add more help texts to MDIMs dropdown options * typo * add description * cases_tests * add missing dependency regions * fix map brackets * add description key in vax by manuf * add description key to testing * fix map bracket sin xm * remove unnecessary schema reference * wip vax breakdown * wip * wip * wip * change function, deprecate it * wip: expand_views * wip: automate view generation * wip * MDIM config auto-generate improvements * automate mobility covid MDIM * MDIM on vax breakdown can't really be used atm * minor cleaning * minor fix * minor fix * remove unnecessary dependency --------- Co-authored-by: Martin Račák <rakyi@users.noreply.github.com> Co-authored-by: Martin Račák <martin.racak@ourworldindata.org> Co-authored-by: Pablo Rosado <pabloarosado@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
table#indicatorinstead of full catalogPathgrapher/energy/2024-06-20/energy_mix/energy_mix#coal__twh->energy_mix#coal__twhmultidim.upsert_multidim_data_page, but you have to passdependencies=paths.dependencies(I couldn't think a more elegant way, but I'm all ears if you do).read(..., load_data: bool)which doesn't load data when used. This significantly reduces loading times for huge datasets like GBD