Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non deprecated resnet weights to compute camelyon16 features #294

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Use non deprecated resnet weights to compute camelyon16 features #294

merged 4 commits into from
Jan 4, 2024

Conversation

xavier-owkin
Copy link
Contributor

@xavier-owkin xavier-owkin commented Jan 4, 2024 •
edited by jeandut
Loading

Using pretrained=True to load a resnet's weight in pytorch is now deprecated.
This PR:

  • uses the new supported way of loading weights
  • fixes a typo on remove_big_tif argument within the main function called in the tiling script

jeandut
jeandut reviewed Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@jeandut jeandut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !
Can you:

  • fill PR description with something more descriptive than "improve"
  • rebase on main once histolab tiling is merged and add the link to pytorch doc ?

@xavier-owkin xavier-owkin changed the title Improve camelyon16 features Use non deprecated resnet weights to compute camelyon16 features Jan 4, 2024
@xavier-owkin xavier-owkin marked this pull request as ready for review January 4, 2024 16:12
@xavier-owkin xavier-owkin requested a review from a user January 4, 2024 16:12
jeandut
jeandut approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@jeandut jeandut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@jeandut jeandut merged commit b9fa41d into main Jan 4, 2024
5 checks passed
@jeandut jeandut deleted the improve-camelyon16-features branch January 4, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeandut jeandut jeandut approved these changes

@maikia maikia Awaiting requested review from maikia maikia is a code owner

@tanguy-marchand tanguy-marchand Awaiting requested review from tanguy-marchand tanguy-marchand is a code owner

@regloeb regloeb Awaiting requested review from regloeb regloeb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavier-owkin @jeandut