Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

deleting audio files does not delete them from the users media playlist #349

Closed
butonic opened this issue Dec 14, 2012 · 4 comments
Closed
Assignees

Comments

@butonic
Copy link
Contributor

butonic commented Dec 14, 2012

The playlist is stored in the browsers localStorage, so the delete hook has no way of updating the playlist there. Doing a rescan does not remove the files as well. We could check the playlist when loading the player and remove deleted items. @icewind1991 @jancborchardt what do you think? since we do not store the playlist on the server and cannot load or save them this might be the simplest soluton.

@ghost ghost assigned icewind1991 Dec 14, 2012
@butonic
Copy link
Contributor Author

butonic commented Dec 14, 2012

we should at least skip the files when the player reaches them but cannot find them

@jancborchardt
Copy link
Contributor

Yeah, your proposed solution sounds good. People should not have to manually rescan either way.

@butonic
Copy link
Contributor Author

butonic commented Jan 14, 2013

I have skipping of files working. Some minor issues before I create the pull request @jancborchardt Should I really delete missing files from the playlist?

@ghost ghost assigned butonic Jan 14, 2013
@jancborchardt
Copy link
Contributor

@butonic hmm, maybe it’s better to not delete the missing files but just mark the playlist entry, e.g. with a yellow-ish background and maybe a tipsy note (»song could not be found«). That would not destroy people’s playlists, just skip these tracks, and allow to either reupload the source file to fix it or to delete the entry from the playlist.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants