-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deleting audio files does not delete them from the users media playlist #10
Comments
we should at least skip the files when the player reaches them but cannot find them Original comment by @butonic at owncloud-archive/apps#349 (comment) |
Yeah, your proposed solution sounds good. People should not have to manually rescan either way. Original comment by @jancborchardt at owncloud-archive/apps#349 (comment) |
I have skipping of files working. Some minor issues before I create the pull request @jancborchardt Should I really delete missing files from the playlist? Original comment by @butonic at owncloud-archive/apps#349 (comment) |
@butonic hmm, maybe it’s better to not delete the missing files but just mark the playlist entry, e.g. with a yellow-ish background and maybe a tipsy note (»song could not be found«). That would not destroy people’s playlists, just skip these tracks, and allow to either reupload the source file to fix it or to delete the entry from the playlist. Original comment by @jancborchardt at owncloud-archive/apps#349 (comment) |
The playlist is stored in the browsers localStorage, so the delete hook has no way of updating the playlist there. Doing a rescan does not remove the files as well. We could check the playlist when loading the player and remove deleted items. @icewind1991 @jancborchardt what do you think? since we do not store the playlist on the server and cannot load or save them this might be the simplest soluton.
Originally reported by @butonic at owncloud-archive/apps#349
The text was updated successfully, but these errors were encountered: