-
Notifications
You must be signed in to change notification settings - Fork 76
add ability to import ics attachments into the calendar #1473
Conversation
By analyzing the blame information on this pull request, we identified @jakobsack, @DeepDiver1975 and @jancborchardt to be potential reviewers |
} | ||
}); | ||
var props = [ | ||
'{' + dav.NS_DAV + '}displayname', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristophWurst I assume dav.NS_* are all undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are only defined in calendar: https://github.com/owncloud/calendar/blob/8e32fee4f2bf1346e987c23d2d0ab05cebcefd40/js/app/service/davclient.js#L39-L43
1b6dc31
to
f0a470d
Compare
Ooooh that's awesome! :) I would now even (maybe) for the ics files consolidate the download and save to Files action into a 3-dot menu cause they are leaa important now. |
That's my plan, but I'd rather do that in a follow up PR |
@DeepDiver1975 when PUTing the file to the selected calendar, I get the following error:
Any idea what I'm doing wrong? |
3a145ed
to
77a944a
Compare
I'd like to refactor the code a little bit to allow registering different attachment preview generators so we can preview other file types too in the future. To keep this PR reviewable, I will do that in a follow-up PR. |
3f9d13c
to
ae0bc70
Compare
|
4b0163b
to
6d08fa4
Compare
@jyaworski @jancborchardt @Gomez @tahaalibra @DeepDiver1975 this is ready to review :-) |
exports: 'dav' | ||
}, | ||
ical: { | ||
exports: 'ICAL' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- rebase destroyed the json structure
f67b033
to
9bc8021
Compare
@tahaalibra the + Button is only shown for the MIME type 'text/calendar'. Could you please check the MIME type of that file? I assume it's a different type as the calendar icon is also not shown. |
i am talking about file meetup.ics, its the same file on both email (ignore contact_birt..) |
Me too. Check the icon, it's not the same ;-) Could you please debug this so we know what exact MIME type the second file has? Thanks |
d6fa70c
to
1876bb9
Compare
Works perfect for me. Lets get it in and solve following problems on the way... |
fixes: https://github.com/owncloud/mail/issues/79
TODO:
BUGS:
HTTP/1.1 400 Every VEVENT in this object must have identical UIDs
FUTURE IDEAS