Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

UI test to disable user #25

Conversation

paurakhsharma
Copy link
Contributor

UI test for disabling users.
Tested locally.
It's failing because of #24
cc @phil-davis

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
You should be able to implement this code.n core stable10 an it will pass. So that would be good to do to prove the test infrastructure is working fine,.

@paurakhsharma paurakhsharma force-pushed the ui-test-for-disabling-users branch from b41b1b8 to 4253ab3 Compare April 23, 2018 06:33
@codecov-io
Copy link

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage     77.85%   77.85%           
  Complexity      186      186           
=========================================
  Files            19       19           
  Lines           754      754           
=========================================
  Hits            587      587           
  Misses          167      167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d73902...4253ab3. Read the comment docs.

@phil-davis
Copy link
Contributor

The core master PR has been merged.
@paurakhsharma please rebase this tomorrow.

@phil-davis
Copy link
Contributor

See #41 for a rebased version of this. That PR also skips the test, so that we can at least merge the code.

@phil-davis phil-davis closed this Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants