No white theme in 0.9.9.13 fdroid

[franciscot]

In the last version in fdroid 0.9.9.13 there is not white theme anymore.
There are two options dark or brilliant (less dark).
Is it a bug or white theme is not support anymore?

Thanks.

[David-Development]

Thanks for the feedback. The white ("light") theme should still exist. I added an additional theme for OLED screens. There should be three themes in the settings that you can choose from.

[franciscot]

It seems that the light theme is only shown with the English (USA):

[David-Development]

Oh.. that sucks. Thank you for the detailed information!

Since the translations are provided by the transifex community there is not much I can do. However Android should use the english translation if it can't find the corresponding one in other languages.

[franciscot]

In case it helps you in any way:
I changed the app theme to bright in English. Then I changed the system language back to Spanish and the application crash when I try to access the settings in Spanish.

[David-Development]

Yes, this is an Android Bug. If the translations are not complete, the app will crash. Unfortunately there is nothing I can do about that. I received a bunch of new translations from the nextcloud translation service (transifex). It still looks like the spanish translation is not complete yet. I'm sorry for the inconveniences. And thank you so much for providing so much feedback! It helped me a lot to understand the problem!

[filipesaraiva]

Same here but with Portuguese. Will it be fixed in next release?

[cjd]

Similar problem here with locale English(Australian)
The "light" theme is black while the "dark" theme is Gray. There is on OLED option shown

[flocke]

Got a similar issue with 0.9.9.14 on Google Play with "English (Germany)". It only shows "Dark" as option.

What I don't understand is why this happens with the "English (xyx)" locales as well. Shouldn't they use the default resources from the "values" folder since no "values-en-rXYZ" folder exists?

[David-Development]

@mario Since the last release I have some serious inconsistencies in the Translations provided by Transifex. Some of the existing translations are messed up and invalid xml is being pushed back to the repo. For example: https://github.com/nextcloud/news-android/blob/master/News-Android-App/src/main/res/values/strings.xml#L187

In the "Finish" translation this string-array is divided into a string and a broken string-array.. see https://github.com/nextcloud/news-android/blob/master/News-Android-App/src/main/res/values-fi-rFI/strings.xml#L145 and https://github.com/nextcloud/news-android/blob/master/News-Android-App/src/main/res/values-fi-rFI/strings.xml#L152

Is there anything I can do to fix this problem? The Android App crashes if there are no translations for a given language so I think if I simply remove the translations from the commit, the App will crash on all devices that use the given language..

@cjd, @flocke Thanks for the feedback. The app does not support values-en-* (except for GB). As the Android Docs state, missing translations will cause app crashes. I think this behavior is not useful at all. It's a very poor design choice Android made here.. Open Source Apps depend on the community to provide translations (such as transifex). Not all translations are provided within 24 hours.. so it might take a few days or even weeks or month to integrate all translations. And I think it is unacceptable to experience app crashes just because they won't use english as fallback..

[mario]

@David-Development items should not be declared like that. Instead for every item you need a string, and then inside your string-array you define them like

<item>@string/whatever_string_resource_name</item>

This will solve your problem as the size of the array will always be the same, even if something isn't translated. :)

[David-Development]

@mario I see. Nice workaround! Thanks for the hint! 👍I'll fix this in the next release!

[mario]

👍 Glad I could help @David-Development :)