Don't rely on phpunit/php exit code in CI

[DeepDiver1975]

Better evaluate the report xml
see https://github.com/owncloud/core/blob/54cd970b0adf4cc08362aeb0e9876d999d7bd255/build/autotest.sh#L342 how to generate

using xml tools the number of failed/errored unit tests can easily be determined

[patrickjahns]

@DeepDiver1975

Investigated the reports and found that the xml report is not reliable on phpunit 5.7.x - it will not list warnings :'(
https://gist.github.com/patrickjahns/05481849722e162c2e5efc5c369e591f

PHPUNIT 5.7.x allows also for json and teamcity reports, which would include warnings.
However - phpunit 6 has deprecated --log-json format

[patrickjahns]

Some more findings - logIncompleteSkipped="true" might log the warnings - double checking

[patrickjahns]

Annoyingly - junit from phpunit is also not "proper" junit xml - it will have testcase and testsuite elements on the same level for dataproviders

<testsuite>
<testcase></testcase>
<testsuite><testcase></testcase></testsuite>
<testcase></testcase>
</testsuite>

See: https://gist.github.com/patrickjahns/05481849722e162c2e5efc5c369e591f#file-junit-phpunit-5-7-27-incomplete-skipped-xml

[patrickjahns]

As talked - only important for us is to know in the end if we encountered: failures, errors and warnings - we can easily grep them via xpaths //failures

When logIncompleteSkipped is set - we can/need to filter out allowed failure/error events (i.e. PHPUnit_Framework_IncompleteTestError ref: https://gist.github.com/patrickjahns/05481849722e162c2e5efc5c369e591f#file-junit-phpunit-5-7-27-incomplete-skipped-xml-L33 )

[patrickjahns]

Some time ago in another universe I started to work on a parser in go to parse the junitxml and then return exit code 0 || >0
https://gist.github.com/patrickjahns/a3505a7dec49e7780097a00dd02856e5

Would probably 0.5-1md to pick it up and create a small drone plugin to finish it. ( Or write it in another language || research if there is a parser in php? )

Maybe investigate https://github.com/RazeSoldier/JUnitLogParser and create a little phar tool that we can utilize for it?

[patrickjahns]

@phil-davis @individual-it
As you've been working on phpunit - please consider to write a small tool that parses the phpunit files and returns a proper exit code. This makes us independent when exit codes of phpunit fail to report