Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on phpunit/php exit code in CI #641

Open
phil-davis opened this issue Mar 10, 2020 · 0 comments
Open

Don't rely on phpunit/php exit code in CI #641

phil-davis opened this issue Mar 10, 2020 · 0 comments
Labels
QA:team QA-p3

Comments

@phil-davis
Copy link
Contributor

We have had some times in the past when there have been errors/failures reported in a phpunit test run, but phpunit exits with status 0.

I have not noticed it with phpunit7 (that is used since core 10.4.0) but have not been looking hard either!

Consider the comments in issue #550 - maybe add some code in CI that parses the output of phpunit and will make the test run fail if "bad stuff happened". #550 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA:team QA-p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phil-davis