Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test plan PR 1100: Fab created #161

Merged
merged 4 commits into from
Mar 7, 2016
Merged

Add test plan PR 1100: Fab created #161

merged 4 commits into from
Mar 7, 2016

Conversation

jesmrec
Copy link
Contributor

@jesmrec jesmrec commented Mar 1, 2016

No description provided.

@jesmrec jesmrec added this to the Android 1.9.2-current milestone Mar 1, 2016
@jesmrec jesmrec mentioned this pull request Mar 1, 2016
@AndyScherzinger
Copy link

Hi @jesmrec just some minor questions and possible additions :)

  • is view/5 a test for orientation change as in open fab change device orientation --> fab stays opened (at least that is how I implemented it, so the open state is preserved)
  • test cases I am missing (but already tested myself) are with regards to the back button logic
    • scenario 1
      • fab opened
      • hit back button
      • fab collapses
    • scenario 2
      • fab is opened
      • drawer is opened
      • hit back button
      • drawer closes
      • hit back button
      • fab collapses
  • long click test: long click on the mini fabs shows a Toast naming the action triggered by the mini fab you long clicked :)
  • theoretical ones since the implementation had to take care of this, no fab shown in "other" list views:
    • no fab shown in Upload file list view
    • no fab shown in copy/move list view

Besides my suggested additions great work imho covering all scenarios possible! 👍

@jesmrec
Copy link
Contributor Author

jesmrec commented Mar 7, 2016

@AndyScherzinger thank you very much for your suggestions. I will take it in account by adding some test cases in the test plan 👍

@davivel
Copy link
Contributor

davivel commented Mar 7, 2016

Then now it's 👍

davivel added a commit that referenced this pull request Mar 7, 2016
Add test plan PR 1100: Fab created
@davivel davivel merged commit df6320c into master Mar 7, 2016
@jvillafanez jvillafanez deleted the material_fab_android branch April 5, 2016 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants