Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testplan minor release #706

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Conversation

gabi18
Copy link
Contributor

@gabi18 gabi18 commented Dec 14, 2021

Added some missing 'heavy_check_mark' and 'construction'

@gabi18 gabi18 requested a review from Talank December 14, 2021 09:39
@gabi18
Copy link
Contributor Author

gabi18 commented Dec 14, 2021

@Talank @swoichha Could you please check esp. 6 / 2 (does the x mean, the test failed/still fails?) and 9.1 / 5 (test also fails?) and confirm that all automated tests now are marked correctly.

@gabi18 gabi18 requested a review from swoichha December 14, 2021 09:59
@swoichha
Copy link
Contributor

@gabi18 I'll look into it and get back to you.

@swoichha
Copy link
Contributor

swoichha commented Dec 15, 2021

@gabi18 we did not add the ❌ in 6/2. I think it was there while we manually tested for 2.9. For 9.1/5 we just added a 🤖 and the name of the file where the test have been added (i.e. tst_sharing). Both of these tests have been automated and it passes on CI as well.

All the gui tests that fails are either skipped or are reported in CI logs. Also, we have not completely edited the file which marks the tests that are automated. Hopefully after we close this issue owncloud/client#8971 we can confirm which tests have automated.
cc: @Talank

@gabi18
Copy link
Contributor Author

gabi18 commented Dec 15, 2021

@gabi18 we did not add the x in 6/2. I think it was there while we manually tested for 2.9. For 9.1/5 we just added a robot and the name of the file where the test have been added (i.e. tst_sharing). Both of these tests have been automated and it passes on CI as well.

Thanks for having a look. I have added the heavy_check_mark to 6/2. and 9.1/5.

All the gui tests that fails are either skipped or are reported in CI logs. Also, we have not completely edited the file which marks the tests that are automated. Hopefully after we close this issue owncloud/client#8971 we can confirm which tests have automated. cc: @Talank

@swoichha @Talank
If you agree I will merge this pull request now to have an overview which tests are already automated. More tests can be added later.

Copy link
Contributor

@swoichha swoichha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabi18 This looks good to me we can merge this. But, I think we need to make an extra column for squish test where we can add ✔️ ❌ 🚧 so that we can have two column one for squish tests and one for manual tests.

Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like @swoichha said, we can discuss that later on how to distinguish tests that are automated. For now, changes made in this PR looks good to me as well.

@gabi18 gabi18 merged commit 6f54e2f into master Dec 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the improve-testplan-minor-release branch December 16, 2021 09:07
@gabi18
Copy link
Contributor Author

gabi18 commented Dec 16, 2021

@swoichha @Talank Thanks for your review and ideas. My idea concerning the Result column was to use it for automated and manual tests. The result for a squish test is always ✔️, all failures must be fixed before building the beta/RC candidates. We have added to the prerequisites of the release ticket template that all squish tests have to be successful https://github.com/owncloud/client/blob/master/.github/patch_release_template.md.
We will see how the test plan works for the next release and can apply improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants