[FEATURE REQUEST] Improvements in "Manage accounts" view

[jesmrec]

EPIC:

• [EPIC] New "Manage accounts" view #4314

This is the current look of the Manage accounts:

• Text field containing the username@url overflows the space and overlaps other icons on the right (check https://github.com/owncloud/enterprise/issues/5986#issuecomment-1693193046).

• Round arrow icon will be removed -> [FEATURE REQUEST] Make automatic discovery of the account #4301

• Key icon could be removed (after research on Cookie handling #4227). In case credentials are lost, Snackbar with Sign In option is in the file list. May need to check if removing the key icon could carry other side-effects

TASKS

• Research (if needed)
• Create branch feature/improvements_in_manage_accounts_view
• Development tasks
  • Avoid overlapping between the username and the icons
  • Remove key icon
  • Make lost-credentials Snackbar equal for every auth (with the Sign in option in basic auth too)
• Code review and apply changes requested
• Design test plan
• QA
• Merge branch feature/improvements_manage_accounts into master

[jesmrec]

About the key icon: removing is not a problem whether the account is token-based (OAuth2, OIDC) because the Sign-in snackbar is there to regain authentication.

But, if the account is basic auth and password changes in server, there is no way to get Sign-in snackbar because there are no available sessions (basic auth works with an authenticated header). Key icon is required to re-enter a new one.

So, i'd keep it for basic auth accounts and remove for token accounts (if feasible).

CC @michaelstingl

[michaelstingl]

But, if the account is basic auth and password changes in server, there is no way to get Sign-in snackbar because there are no available sessions (basic auth works with an authenticated header). Key icon is required to re-enter a new one.

So, i'd keep it for basic auth accounts and remove for token accounts (if feasible).

CC @michaelstingl

When passwords change on the server, clients receive 401's too. This should trigger re-login.

[jesmrec]

there is no 401 because server creates a new session (new cookie) that supports it without losing auth. Making this work with basic auth will trigger probably deeper and tricky changes (needs research to accurate). This is the issue:

[jesmrec]

Well, kept testing it and after some time, 401 is returned, but the snackbar is different:

no way to regain auth, only to select another account.

[jesmrec]

iOS approach in account management:

List of accounts	Options of every account	No access	Regain access

Some inputs to move Android approach to the iOS one:

• Android app will remove sync option and make it automatic somehow (new issue)
• Change account in basic auth may need redefinition to be similar to browser auth. Then, it could be removed from account manager
• Manage in iOS removes all downloaded files from the account. New feature in Android with two options: manual and auto. Check how to integrate in the accounts manager view
• Android app lacks of a "log out" option. [QA] no logout from identity provider possible #3872. Out of scope of this issue, imho

more ideas?

[jesmrec]

In order to remove the key icon and make behaviour consistent between browser/no browser authentication:

• Cookies to be removed every time the app is killed. It'll force the app to ask for a new one once it's open again. In case password changed, 401 will be returned

• If basic authentication is lost (password changed, user disabled), show snackbar with same message of browser auth instead of the current

• Redirection message in snackbar must prompt to login view instead of manage accounts view.

Achieving these, we'll be in position to remove the key icon.