Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long click on a file should allow to mark it as a favorite #786

Closed
tobiasKaminsky opened this issue Dec 7, 2014 · 9 comments
Closed

Long click on a file should allow to mark it as a favorite #786

tobiasKaminsky opened this issue Dec 7, 2014 · 9 comments

Comments

@tobiasKaminsky
Copy link
Contributor

If you want to mark multiple files as favorite it is time consumption to first open the detail page and then select "keep file uptodate".
@jancborchardt What do you think?

@jancborchardt
Copy link
Member

Long-press should select the file and initiate multiselect-mode. That would then also allow you to batch-favorite files.

@rperezb @davivel

@tobiasKaminsky
Copy link
Contributor Author

Currently after long pressing a context menu is displayed. And in this context menu the "keep file uptodate" should be visible.
Then one could use this faster.

@jancborchardt
Copy link
Member

Yeah, that’s what currently happens. However, because it seems convention to have:

  • the context menu displayed when clicking on »three dots« to the right of an item/row
  • batch selection mode initiated when you long-press on an item

We should change to those paradigms. What do you think?

@jancborchardt
Copy link
Member

Ah wait – I misread. You mean simply adding »Keep file up to date« to the long-press menu, right? In this case yes, I’d agree. ;)

@jancborchardt
Copy link
Member

However, we need to switch from long-press menu to three-dots menu.

@rperezb
Copy link

rperezb commented Dec 11, 2014

Thanks, is it to ok to focus here on just adding the keep-up-to-date option to the long press menu over files?
Besides, could it be a good idea to rename it, everywhere, to favorite?
IT was talked previously and this is how it is called on the iOS app

@jancborchardt about the three-dots menu I will create a new issue

@jancborchardt
Copy link
Member

Yeah, let’s rename it to »Favorite« everywhere.

@purigarcia
Copy link
Contributor

It is done in #1050 .

@purigarcia purigarcia self-assigned this Jul 10, 2015
@rperezb rperezb added this to the 2015-sprint-17-current milestone Jul 16, 2015
@davivel davivel closed this as completed Jul 29, 2015
@davivel
Copy link
Contributor

davivel commented Jul 29, 2015

Merged into develop, will be released with version 1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants