Long-press should initiate multiselect, not show context menu

[jancborchardt]

@davivel @rperezb @tobiasKaminsky

(Edited the title after @joeplus's comment.)

[joeplus]

May I make another comment regarding the long press? Since KitKat Google introduced a new usage of the long press gesture (at the bottom of the page), which now should be used for selection of items. The actions should be moved from the pop up to the action bar. Is this something you guys have already considered to implement long term (maybe with the new drawer and action bar combo)? For now a header makes sense of course!

[masensio]

As @joeplus said, we can introduce the new long press gesture.

This would mark the selected file and would improve the appearance of the contextual menu, if the pop up is replaced by a contextual action bar (CAB). (https://developer.android.com/design/patterns/selection.html )

In this case, we need to decide which options have to appear in the contextual menu.

[jancborchardt]

Yeah – long-press should ideally initiate multi-select mode. As already mentioned in the past: #786 (comment)

Then we need to add a 3-dots-icon to each row (on the right) which then invokes the context menu for each file.

[joeplus]

Sounds great! Here is an example of how the three dots could be implemented, just in case.

Another question: Is the content for the listitem popup the exactly the same as the actionbar popup, thus having to different places for the same actions?

[stefan-niedermann]

duplicate of #426 ?

[radziu82]

No Not duplicate. 426 is closed. This is needed basic functionality.

[jancborchardt]

@davivel @masensio @rperezb @MTRichards where are we at with this? Deletion of multiple files is basically impossible (that is, a huge pain) due to multiselect not existing.

[rperezb]

@jancborchardt for the moment this is not expected.
Certainly, multiselection is needed as well as the improve on the UI, roadmap

[jancborchardt]

Let’s move it up then @MTRichards @rperezb

[tobiasKaminsky]

PR will be #1090 by @AndyScherzinger

[jancborchardt]

@tobiasKaminsky isn’t that just about multiselect for upload?

[AndyScherzinger]

Haven't had this issue in the radar yet

[tobiasKaminsky]

Ah. Maybe. I just had read the title.
And then it would fit, right? ;)
@jancborchardt If it is just for upload, maybe you can clarify it in the issue description?

[jancborchardt]

@tobiasKaminsky well this issue is about the app in general, everything excwpt the uploads view. ;) The normal files list, multiselect for that.

[tobiasKaminsky]

I would also say that this is the next really big and important improvement that we should challenge right after #819 (which I have nearly finished).

[tobiasKaminsky]

As @masensio said here #899 (comment) a long press would also bring the action for one single file, so "Then we need to add a 3-dots-icon to each row (on the right) which then invokes the context menu for each file." as @jancborchardt said (#899 (comment)) should not be needed, right?

[tobiasKaminsky]

Currently design with no functionality.
The checkboxes are only shown if one item is selected and disappear if no item is selected.
@jancborchardt the color of the selected items is set to #1D2D44, but seems to be lightened up by android...
(Of course the position of th checkbox in the square images is not correct).

[tobiasKaminsky]

CAB will include:
if one item selected: all items from currently long press menu
if > 1 item seletced: download, move, copy, delete

[jancborchardt]

Make the color a light grey then, that will look much better (so it looks like #f8f8f8 as on the web interface).

Also, the grid lines in thumbnaip view shouldn't be there.

[AndyScherzinger]

The grey coloring gets even more important when #1090 is merged, due to the accent colored ticked checkboxes.

[jancborchardt]

Yeah, also because the boxes themselves are already a very present indication. Only a slight row highlight is needed, if at all.

[AndyScherzinger]

@tobiasKaminsky I added further icon work for material design purposes :) - One bug I found though is when you select just one them and rotate the screen the whole menu in the action bar is gone. Haven't investigated why this happens though.

[tobiasKaminsky]

Can you open a new issue for this?

[AndyScherzinger]

Done, please see #1411 I guess it is a save instance issue.

[malkomich]

Hi guys,
I have been reviewing the PR #1176 and I have seen that the checkboxes are not always aligned:

In list view they could be aligned right always regardless if there are share icons or not, or maybe just keep the highlight and the top bar information about items selected and not the checkboxes.

For the grid view, the checkboxes could be more neccesary, but they could be shown at the top left size of each item to keep alignment:

About the favorite options, it would be better hide these options on multiple selection when a folder is selected, because it is a feature for files only.

[AndyScherzinger]

@malkomich something seems of since the multi select branch implementation has other icons and some newer themeing, see screenshots here: #1434

[tobiasKaminsky]

I have updated the branch with latest master.
Now it looks this way:

[AndyScherzinger]

I fixed the layouting (and coloring) for the action bar and the list items, see 0ef2389

[AndyScherzinger]

@tobiasKaminsky I think @malkomich's point is that due to the fact that some elements are rendered with the file name so the check box is aligned differently. @jancborchardt any idea how this could be solved? The only thing I I can think of is to find a smart way to center the checkbox on each item or we need to find. Google photos for example has the checkbox in the top left corner.

[tobiasKaminsky]

For me there are two different approaches, when entering multiselect:

• show only the checkmarks, as the other icons are unimportant
• keep every icon: move checkmarks to top left

[AndyScherzinger]

True, not showing that info in multi select mode could also be an option I guess. So waiting for @jancborchardt's input since he is the expert :)

[tobiasKaminsky]

Rethinking it, is not such a good idea, I think: what if you want to select all favorite items to unfavorite them?
So we should find a way to have the checkboxes shown with all other items!

[AndyScherzinger]

Yeah, that is right. So sticking with top left is probably the easiest approach at the moment.

[tobiasKaminsky]

Do you want to do this in the multiSelect branch? :)

[AndyScherzinger]

Sure thing :) Gimme a second 😁

[AndyScherzinger]

@tobiasKaminsky can you take care of the rotation bug regarding the action bar menu? :)

[tobiasKaminsky]

I will do this tomorrow morning

[AndyScherzinger]

Sweet! :)
Changes for the checkbox have been pushed to the branch.

[tobiasKaminsky]

👍 looks great :)

[AndyScherzinger]

I now also commited the logic to show hide the fab entering/exiting multi selction mode 😬 cca2e60

One thing I realized, might be something to deactivate with a flag is that if you do move or copy the file/folder chooser dialog also has multi selection mode which probably doesn't make sense.

[davivel]

In, and ready to go with version 2.1.0.