Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share with users & groups #1252

Merged
merged 69 commits into from
Nov 5, 2015
Merged

Share with users & groups #1252

merged 69 commits into from
Nov 5, 2015

Conversation

davivel
Copy link
Contributor

@davivel davivel commented Nov 4, 2015

No description provided.

masensio and others added 30 commits October 30, 2015 15:04
@davivel
Add 'Share with users/groups' to long press menu
3a527a8
@davivel
Show share with users option if the server supports search users func…
a94c176 
…tion
@davivel
Add new attribute to OCFile to know if this file is shared with users…
e50bc09 
…/groups
@davivel
Create the layout to share with a user
8e3d7bd
@davivel
Add new attribute to OCFile to know if this file is shared with users…
c288f91 
…/groups
@davivel
Show the layout to hsare with user in phone and tablet
f28faf0
@davivel
Add get list of users in the library
c6c5b73
@davivel
Add Get Users from Server Operation
5a14928
@davivel
Add Get Groups operation
263152a
@davivel
Create the layout for searching users/groups
2855a81
@davivel
Changed title in sharing dialog from 'Share link' to 'Sharing' (seen …
bc5687b 
…in web UI)
@davivel
Show the 'search' layout in phone and tablet
905b68b
@davivel
Sync user and group shares into database
0db4fc9
@davivel
Remove android.support.widget components from the sharewith view. Wai…
00a221e 
…ting for introducing Floating button in the project
@davivel
fix Travis
88eca70
@davivel
Show users/groups in share with view, getting the data from the server
20b0ec8
@davivel
Get shares from Database (WIP)
72987c2
@davivel
Complete search widget to send search requests to parent activity
e3d509a
@davivel
Get shares from Database, fix in insert shares in DB
55dc0da
@davivel
Add unshare with user option to share with view
fff362d
@davivel
Animate unshare button
3de67c4
@davivel
Add new string for share_groups_indicator
1fbc44b
@davivel
Clean code in ShareFileFragment
e0813be
@davivel
Users and groups retrieved from server to fill search suggestions
305536f
@davivel
Add unshare with users/groups, from Share wiht view
1bdd672
@tobiasKaminsky @davivel
fixed travis bug
fc0dfec
@davivel
Removed redundant ArrayList creation
1fae1f1
@davivel
Change ShareActivity type, now it is a FileActivity
de93a66
@davivel
Grant that any suggestion may be selected without software keyboard o…
dea69d5 
…verlapping
@davivel
Removed option to refine suggestions in edit field
043d212
davivel and others added 14 commits October 30, 2015 16:52
@davivel
Fixed error messages for user using getLogMessage()
30aa3fd
@davivel
Removed check of NULL after code review
ba694cb
@davivel
Fix: Having the device in landscape current shared users are not show…
f1bd33c 
…n. Redimension 'Share with' dialog
@davivel
Avoid fullscreen searchview when editing
c5ba47d
@davivel
Fix share with user/group when displayname!=username
7b0ec3d
@davivel
Remove commented code
ed89b91
@davivel
Give ALL_PRIVILEGES when create a Share with User/Group
fc2ac64
@davivel
Fixed error messages related with network in ShareActivity
aa4f47c
@davivel
Renamed SearchFragment to SearchShareesFragment
f912415
@davivel
Fixed NPE on list of shares in SearchShareesFragment; and some clean-up
d4df65d
@davivel
Simplified handling of life cycle in ShareActivity to grant nice oper…
f4ae62c 
…ation

while navigating and rotating
@davivel
Refactoring: a single method to request ShareActivity
d89488e
@davivel
Let server decide default permissions for new share
58559b7
Update Library Reference: add unit test for Sharee operations
4ce1ed1
@davivel
Copy link
Contributor Author

davivel commented Nov 4, 2015

Last commits here are mine, so @masensio should review.

Other reviews will be also very appreciated. cc @AndyScherzinger @tobiasKaminsky @LukeOwncloud

@davivel
Copy link
Contributor Author

davivel commented Nov 4, 2015

Implements #880

@davivel davivel added this to the 1.8.1-current milestone Nov 4, 2015
@davivel
Copy link
Contributor Author

davivel commented Nov 4, 2015

Depends on owncloud/android-library#90

@AndyScherzinger
Copy link
Contributor

Looks good to me just two minor things regarding dimens.xml

  • where is fab_margin used (only fab implementation I am aware of is in the respective feature branch)
  • dimens.xml contains dimen properties which at least up to now have been put into dims.xml thus they should be kept in one file

besides that 👍

@davivel
Copy link
Contributor Author

davivel commented Nov 5, 2015

Thanks, @AndyScherzinger , I will check it.

@davivel
Copy link
Contributor Author

davivel commented Nov 5, 2015

Totally unneeded file. We started the new activity testing the Dialog theme from code generated by an Studio template, the file was introduced then.

Good catch!

@AndyScherzinger
Copy link
Contributor

Glad I could help! :)

@masensio
Copy link

masensio commented Nov 5, 2015

👍 :)
Waiting for travis

masensio pushed a commit that referenced this pull request Nov 5, 2015
Merge pull request #1252 from owncloud/share_with_users
7e96305 
Share with users & groups
@masensio masensio merged commit 7e96305 into master Nov 5, 2015
@masensio masensio deleted the share_with_users branch November 5, 2015 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Approved by qa
Projects
None yet
Milestone
1.9-current
Development

Successfully merging this pull request may close these issues.
6 participants
@davivel @AndyScherzinger @masensio @LukeOwlclaw @jesmrec @tobiasKaminsky