Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Hardware keyboard support #4438

Merged
merged 14 commits into from
Jul 31, 2024
Merged

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Jul 16, 2024

Related Issues

App: #4366, #4367 and #4368

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@JuancaG05 JuancaG05 self-assigned this Jul 16, 2024
@JuancaG05 JuancaG05 changed the base branch from master to feature/non_text_contrast July 16, 2024 13:04
@JuancaG05
Copy link
Collaborator Author

JuancaG05 commented Jul 16, 2024

New keyboard navigation model (explained in #4368 (comment)) was applied to:

  • FileDisplayActivity (main file list, details view, text preview, audio preview)
  • UploadListActivity (uploads view)
  • FolderPickerActivity (move, copy, choose auto-uploads path)
  • ReceiveExternalFilesActivity (share with ownCloud from external apps)
  • ShareActivity (share)

@JuancaG05 JuancaG05 force-pushed the feature/support_keyboard_navigation branch from cbed218 to ba024a1 Compare July 19, 2024 07:53
@JuancaG05 JuancaG05 marked this pull request as ready for review July 19, 2024 08:04
@JuancaG05 JuancaG05 requested a review from Aitorbp July 19, 2024 08:04
@JuancaG05 JuancaG05 force-pushed the feature/support_keyboard_navigation branch from f155429 to 5c384c7 Compare July 19, 2024 08:12
Copy link
Collaborator

@Aitorbp Aitorbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doubts and changes here @JuancaG05

@JuancaG05 JuancaG05 requested a review from Aitorbp July 19, 2024 11:39
Copy link
Collaborator

@Aitorbp Aitorbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feature/non_text_contrast to master July 22, 2024 09:52
@Aitorbp Aitorbp force-pushed the feature/support_keyboard_navigation branch from 9318fc5 to d60ea29 Compare July 22, 2024 10:02
@jesmrec
Copy link
Collaborator

jesmrec commented Jul 23, 2024

## #4366

Personal Space

  • If the search at the top is not activated, only the buttons at the top of the page (see screenshot) can be accessed using the keyboard. To access the other interactive elements on the page, you must activate the "X" button (see screenshot). However, you can then return to the top elements of the page, which is a limitation for users who use the keyboard.

  • If you tap on a directory or file entry for a long time, a new page opens on which you have the option of selecting directories and files. Unfortunately, this option is not available to keyboard users. Furthermore, it is not immediately apparent to all users that that this option for selecting elements exists.

Share

  • The "Back" button cannot be reached using the keyboard.

Spaces

  • If the search at the top is not activated, only the top buttons on the page (see screenshot) can be accessed using the keyboard. To access the other interactive elements on the page, you must activate the "X" button (see screenshot). However, you can then no longer return to the upper elements of the page, which is a limitation for users who use the keyboard.

Manage accounts

  • The "Back" button cannot be reached using the keyboard. NA

Image Viewer

  • The buttons at the top of the page cannot be focused or activated using the keyboard. They are invisible to keyboard users and only become visible when tapped on the screen. WON'T FIX

#4367

### Personal Space and Menu

Share

  • If you navigate forwards using the TAB key, the entire element under "Users and groups" is focused and you can no longer navigate any further. NOT REPRODUCIBLE, NO TRAP.

#4368

Personal Space and Menu

  • If the keyboard focus is in the "Browse folder" input field, you can no longer navigate to the "Menu" button by pressing the back Tab key (Shift + Tab).

Menu

  • If you change the view of the menu using the keyboard and then press ENTER the sorting menu is opened. This indicates that the sort button in the background has received the keyboard focus. The keyboard focus should remain in the menu until the menu is closed. However, it is not currently possible to close the menu using the keyboard. There is neither a close button, nor did the usual keyboard shortcuts work in the test. -> keyboard trap?

Edit shared Link

  • Both the "Expiry date" label and the date can be focused and activated using the keyboard, as a date picker element is opened. This could confuse users, as the two elements cannot be recognizable as buttons. It would be better to provide a separate button for opening the datepicker element to increase user-friendliness and avoid misunderstandings.

Manage accounts

  • Remark: if the "Account" button is in focus (see screenshot) and is activated, the user returns to the previous page. This is unexpected and should be avoided.

Image viewer

  • Note: pressing the TAB key or the arrow keys loads new images. This could confuse some users. WONT FIX

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 23, 2024

I will list some issues that i found by navigating in a exploratory way. All of them might not be scoped here and could be addressed in another issue/iteration

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 23, 2024

(1) [WONT FIX]

  1. Open list of files
  2. Select hamburger button and open the drawer

Current: it is posible to navigate through items in the drawer, but no way to close it. Esc and other keys do not work to close.

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 23, 2024

(2) [FIXED]

Probably, something not fixable:

  1. Open list of files
  2. Click on Tab till you reach the last item of the file list

Current: three taps on the Tab key required to reach the following element (FAB). It seems like the mini-fabs are also browsed with the Tab, no matter if FAB is expanded or folded.

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 23, 2024

(3) [FIXED]

  1. Open list of files
  2. Browse down to reach the bottom bar
  3. Open the Uploads view (empty, with no uploads)

Current: top bar of uploads view is a keyboard trap. No way to go out.

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 23, 2024

(4) [FIXED]

  1. Open list of files
  2. Long press with Enter over any item to enable multiselection

Current: i saw the attached video in the issue, but i was not able to browse from the list of files to the light-blue to bar to open the list of available operations for the multiselection. I am able to reach the top bar with the search, hamburguer... but not the displayed one

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 23, 2024

(5) [WONT FIX]

The following options:

  • Send
  • Open with
  • Share univ link
  • Share public link

open a system card. I found no way to close it once it is opened. Esc and other keys does not work.

Probably, out of scope.

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 23, 2024

(6) [WONT FIX]

Probably, out of scope.

Security passcode can not be created via keyboard.

@JuancaG05 JuancaG05 force-pushed the feature/support_keyboard_navigation branch from bff1c95 to d60ea29 Compare July 31, 2024 06:55
@JuancaG05 JuancaG05 force-pushed the feature/support_keyboard_navigation branch from 648f5b4 to 56d2ffa Compare July 31, 2024 12:06
@JuancaG05
Copy link
Collaborator Author

Some comments about the QA reports @jesmrec:

  • (1) and (5) are not reproducible for me. Tried with other devices and keyboards and Esc key is working 🤔
  • (2) is solved. Now, mini FABs will only be focusable (and thus reachable with keyboard) when the main FAB is expanded 👍
  • (3) is fixed. If the uploads list is empty, we can now press the down arrow key to move the focus to the bottom bar
  • (4) is fixed as well. Previously there was a strange behaviour with focus since the normal toolbar (which is behind the multiselection toolbar) was still focusable, now when in multiselection mode, only the multiselection toolbar will be focusable, providing the normal navigation behaviour
  • (6) is out of scope, the passcode view was not addressed here, I just worked on the screens included in the report (and those affected transversally due to the toolbar management, listed in [a11y] Hardware keyboard support #4438 (comment))

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 31, 2024

(1) and (5) are not reproducible for me. Tried with other devices and keyboards and Esc key is working 🤔

well, we don't have a reason for this difference in behaviours. Will need some research.

(2) is solved. Now, mini FABs will only be focusable (and thus reachable with keyboard) when the main FAB is expanded 👍

Fixed

(3) is fixed. If the uploads list is empty, we can now press the down arrow key to move the focus to the bottom bar

Fixed

(4) is fixed as well. Previously there was a strange behaviour with focus since the normal toolbar (which is behind the multiselection toolbar) was still focusable, now when in multiselection mode, only the multiselection toolbar will be focusable, providing the normal navigation behaviour

Fixed 💯

(6) is out of scope, the passcode view was not addressed here, I just worked on the screens included in the report (and those affected transversally due to the toolbar management, listed in #4438 (comment))

Will create another issue to handle this.

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 31, 2024

This first iteration that includes the new navigation model is OK. Let's check how it works and keep iterating.

@JuancaG05 JuancaG05 merged commit 01716a6 into master Jul 31, 2024
7 checks passed
@JuancaG05 JuancaG05 deleted the feature/support_keyboard_navigation branch July 31, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y] 11.2.4.3 Focus order [a11y] 11.2.1.2 No keyboard trap [a11y] 11.2.1.1 Keyboard
3 participants