-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Hardware keyboard support #4438
Conversation
New keyboard navigation model (explained in #4368 (comment)) was applied to:
|
cbed218
to
ba024a1
Compare
f155429
to
5c384c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some doubts and changes here @JuancaG05
owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/ShareActivity.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/ShareActivity.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/ShareFileFragment.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
86f1cd8
to
663ea64
Compare
9318fc5
to
d60ea29
Compare
## #4366 Personal Space
Share
Spaces
Manage accounts
Image Viewer
#4367### Personal Space and Menu
Share
#4368Personal Space and Menu
Menu
Edit shared Link
Manage accounts
Image viewer
|
I will list some issues that i found by navigating in a exploratory way. All of them might not be scoped here and could be addressed in another issue/iteration |
(1) [WONT FIX]
Current: it is posible to navigate through items in the drawer, but no way to close it. |
(2) [FIXED]Probably, something not fixable:
Current: three taps on the |
(3) [FIXED]
Current: top bar of uploads view is a keyboard trap. No way to go out. |
(4) [FIXED]
Current: i saw the attached video in the issue, but i was not able to browse from the list of files to the light-blue to bar to open the list of available operations for the multiselection. I am able to reach the top bar with the search, hamburguer... but not the displayed one |
(5) [WONT FIX]The following options:
open a system card. I found no way to close it once it is opened. Probably, out of scope. |
(6) [WONT FIX]Probably, out of scope. Security passcode can not be created via keyboard. |
bff1c95
to
d60ea29
Compare
…n mode, just action mode toolbar
648f5b4
to
56d2ffa
Compare
Some comments about the QA reports @jesmrec:
|
well, we don't have a reason for this difference in behaviours. Will need some research.
Fixed
Fixed
Fixed 💯
Will create another issue to handle this. |
This first iteration that includes the new navigation model is OK. Let's check how it works and keep iterating. |
Related Issues
App: #4366, #4367 and #4368
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA