Fix possible crash

https://sentry.io/organizations/owncloud/issues/2641160195/events/a0519fae20d74fdda4f696270a307bcd/
owncloud · Sep 14, 2021 · e698d56 · e698d56
1 parent f9ce335
commit e698d56
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/changelog/unreleased/9012 b/changelog/unreleased/9012
@@ -0,0 +1,6 @@
+Bugfix: We fixed a crash when using the retry action on an issue
+
+Using the context menu action on a sync issue could cause a crash.
+
+https://github.com/owncloud/client/issues/9013
+https://github.com/owncloud/client/pull/9012
diff --git a/src/gui/protocolwidget.cpp b/src/gui/protocolwidget.cpp
@@ -124,9 +124,11 @@ void ProtocolWidget::showContextMenu(QWidget *parent, ProtocolItemModel *model,
                 case SyncFileItem::SoftError:
                     Q_FALLTHROUGH();
                 case SyncFileItem::BlacklistedError:
-                    menu->addAction(tr("Retry sync"), parent, [&data] {
-                        data.folder()->journalDb()->wipeErrorBlacklistEntry(data.path());
-                        FolderMan::instance()->scheduleFolderNext(data.folder());
+                    menu->addAction(tr("Retry sync"), parent, [data, folder = QPointer<Folder>(data.folder())] {
+                        if (folder) {
+                            folder->journalDb()->wipeErrorBlacklistEntry(data.path());
+                            FolderMan::instance()->scheduleFolderNext(folder);
+                        }
                     });
                 default:
                     break;