Skip to content

Commit

Permalink
macdeployqt: Adjust minimum version based on our Qt #5932
Browse files Browse the repository at this point in the history
  • Loading branch information
guruz committed Apr 3, 2018
1 parent 75241c6 commit e964636
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
7 changes: 7 additions & 0 deletions admin/osx/macdeployqt.py
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,13 @@ def FindQtPlugin(name):
for plugin in QT_PLUGINS:
FixPlugin(FindQtPlugin(plugin), os.path.dirname(plugin))

if LooseVersion(qt_version) >= LooseVersion("5.10.0"):
args = ['plutil', '-insert', 'LSMinimumSystemVersion', '-string', '10.10.0', os.path.join(bundle_dir, 'Contents', 'Info.plist')]
commands.append(args)
else:
args = ['plutil', '-insert', 'LSMinimumSystemVersion', '-string', '10.7.0', os.path.join(bundle_dir, 'Contents', 'Info.plist')]
commands.append(args)

if len(sys.argv) <= 2:
print 'Will run %d commands:' % len(commands)
for command in commands:
Expand Down
4 changes: 1 addition & 3 deletions cmake/modules/MacOSXBundleInfo.plist.in
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,9 @@
<key>CFBundleShortVersionString</key>
<string>@MIRALL_VERSION_STRING@</string>
<key>NSHumanReadableCopyright</key>
<string>(C) 2014-2016 @APPLICATION_VENDOR@</string>
<string>(C) 2014-2018 @APPLICATION_VENDOR@</string>
<key>SUShowReleaseNotes</key>
<false/>
<key>LSMinimumBundleVersion</key>
<string>10.7.0</string>
<key>SUPublicDSAKeyFile</key>
<string>dsa_pub.pem</string>
</dict>
Expand Down

0 comments on commit e964636

Please sign in to comment.