Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] folder pin state is inherited by new files #10035

Closed
2 tasks done
jnweiger opened this issue Aug 16, 2022 · 2 comments
Closed
2 tasks done

[QA] folder pin state is inherited by new files #10035

jnweiger opened this issue Aug 16, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Aug 16, 2022

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the QA issue

Seen while testing #9966 with testpilotcloud 2.11.0daily20220815 (build 8327)

On Linux:

  • Suffix VFS: test how pinning behaves for child items of pinned directories.
    • Initially, the menu entry 'Free up local space' is grayed out e.g. for the 'Photos' folder and also its contents. the state is 'Available online only'.
    • Set folder 'Photos' to 'Make always available locally'
    • Wait for sync. The menu entry 'Make always available locally' becomes grayed out, and "Free up local space" becomes accessible. The state changes to 'Always available locally'.
    • Check the files in the Photos folder. They have the same menue entries grayed out as the folder.
    • Add a new inksc.png file via server Web UI- to the Photos folder.
    • Wait for sync. The file appears at the client. Its state is 'Always available locally'. BAD.
    • Another file added via server web ui outside of Photos appears with state 'Available online only. OK.

Expected behavior according to #9966 (comment)

  • new remote files are online only by default.
  • I interpret that in my case as both, inside and outside of the Photos folder.

Steps to reproduce the issue

.

Screenshots

.

Expected behavior

.

Actual behavior

.

@TheOneRing
Copy link
Contributor

How does it behave with win vfs?

@TheOneRing TheOneRing added this to the 2.11.0 milestone Aug 16, 2022
@jnweiger
Copy link
Contributor Author

Same behaviour seen in onedrive and in win vfs.
Inheriting pin state for new remote files is the intended behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants