Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set the pin state of the root folder but assume unspecified #9966

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Don't set the pin state of the root folder but assume unspecified #9966

merged 1 commit into from
Jul 28, 2022

Conversation

TheOneRing
Copy link
Contributor

@TheOneRing TheOneRing commented Jul 28, 2022 •
edited
Loading

For suffix vfs the code returned always local by default and thus needed the setRootPinState.
Obviously that wrong with anything but he suffix plugin.

For testing:

  • Nothing for Windows VFS
  • Suffix VFS: test how pinning behaves for child items of pinned directories.
  • What happens on enable disable VFS.
  • Adding a folder with files

The expected behavior is:

  • Remote new remote files are online only by default.
  • Existing local files stay available
  • Pin states persist.

@TheOneRing TheOneRing requested a review from a team July 28, 2022 09:34
@TheOneRing TheOneRing changed the base branch from master to 2.11 July 28, 2022 09:41
@TheOneRing TheOneRing added this to the 2.11.0 milestone Jul 28, 2022
dragotin
dragotin approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit f5f9552 into 2.11 Jul 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/pinstate branch July 28, 2022 11:35
@jnweiger jnweiger mentioned this pull request Aug 3, 2022
Closed
56 tasks
@jnweiger jnweiger mentioned this pull request Aug 16, 2022
Closed
2 tasks
@jnweiger
Copy link
Contributor

Not sure about the expected behaviour. This is what I get: #10035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoc fmoc fmoc approved these changes

@dragotin dragotin dragotin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TheOneRing @jnweiger @dragotin @fmoc