Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Advanced settings for sync of large folders missing in GUI #10456

Closed
2 tasks done
HanaGemela opened this issue Feb 3, 2023 · 5 comments · Fixed by #10483
Closed
2 tasks done

[QA] Advanced settings for sync of large folders missing in GUI #10456

HanaGemela opened this issue Feb 3, 2023 · 5 comments · Fixed by #10483
Assignees
Labels
p2-high Escalation, on top of current planning, release blocker QA:team type:bug
Milestone

Comments

@HanaGemela
Copy link
Contributor

HanaGemela commented Feb 3, 2023

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the QA issue

Missing section in setting in GUI - see screenshot. Hana Client doesn't provide these options.

Could be because of VFS?
VFS settings is:
VFS - yes
Enforce virtual files - yes

But that should be only for Win. This is mac client 3.1.0 https://cloud.owncloud.com/index.php/f/5961797

Then I've set:
Define folder sync limit - checked
Folder sync limit - 598

It has been changed in this commit https://gitea.owncloud.services/ownbrander/themes/commit/de01a37d90f01034c13a5b217646f136baeec07d

But the client used for this bug report has been built 4 commits later from https://gitea.owncloud.services/ownbrander/themes/commit/778f872ecec8a7f30de9fae1d8c666c86fb38e71

Steps to reproduce the issue

  1. Build a client with:

Define folder sync limit - checked
Folder sync limit - 598

  1. Check if this settings is available in GUI

I don't think these steps are sufficient. There will be also some other condition for sure

Screenshots

Screenshot 2023-02-03 at 10 10 47

Expected behavior

All settings available

Actual behavior

Missing settings section

@HanaGemela HanaGemela added this to the 4.0 milestone Feb 3, 2023
@TheOneRing
Copy link
Contributor

If vfs is enforced the section which is not affecting vfs, is hidden.
Theme::forceVirtualFilesOption

@TheOneRing TheOneRing closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
@HanaGemela
Copy link
Contributor Author

From ownBrader Check this if you want to enforce native WinVFS.

Mac client should not be affected

@HanaGemela HanaGemela reopened this Feb 3, 2023
@TheOneRing
Copy link
Contributor

True ...

@michaelstingl
Copy link
Contributor

Expectation: These options present in non-experimental branded builds with selective sync

@michaelstingl michaelstingl modified the milestones: 4.0, 3.1.1 Feb 7, 2023
@michaelstingl michaelstingl added p2-high Escalation, on top of current planning, release blocker and removed p3-medium Normal priority labels Feb 7, 2023
@TheOneRing TheOneRing modified the milestones: 3.1.1, 3.2 Feb 7, 2023
@TheOneRing TheOneRing self-assigned this Feb 7, 2023
TheOneRing added a commit that referenced this issue Feb 7, 2023
@TheOneRing TheOneRing linked a pull request Feb 7, 2023 that will close this issue
@HanaGemela
Copy link
Contributor Author

Passed qa 3.2.0.10140-rc1 mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-high Escalation, on top of current planning, release blocker QA:team type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants