Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] GUI does not react when logging in while adding a new account #10621

Closed
2 tasks done
HanaGemela opened this issue Mar 22, 2023 · 9 comments · Fixed by #10656
Closed
2 tasks done

[QA] GUI does not react when logging in while adding a new account #10621

HanaGemela opened this issue Mar 22, 2023 · 9 comments · Fixed by #10656
Assignees
@HanaGemela
Labels
macOS p3-medium Normal priority QA:team Upstream issue
Milestone
Desktop Client 4.0

Comments

@HanaGemela
Copy link
Contributor

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the QA issue

ownCloud 4.0.0.10444-alpha1
mac

Steps to reproduce the issue

  1. Log out of your account
  2. Click Add new account
  3. Minimise the client
  4. Right click on the icon in the top bar
  5. Select the account you're logged out of
  6. Click Log in

Screenshots

No screenshots

Expected behavior

For example: Adding a new account action is not interrupted or the pop-up to confirm the cancellation of adding a new account is shown

Actual behavior

User can't click anything, the pop-up to confirm the cancellation of account setup is hidden somewhere.

To get rid of that state:

  1. Minimise the client
  2. Right click on the owncloud icon in the bottom bar
  3. Select Quit -> The pop-up is finally shown
@HanaGemela HanaGemela added p3-medium Normal priority QA:team labels Mar 22, 2023
@HanaGemela HanaGemela added this to the inbox milestone Mar 28, 2023
@HanaGemela
Copy link
Contributor Author

Similar when the About dialog is opened - user can't click anything

Screenshot 2023-03-28 at 11 00 31

@TheOneRing

This comment was marked as outdated.

Sign in to view
@TheOneRing

This comment was marked as outdated.

Sign in to view
@HanaGemela

This comment was marked as outdated.

Sign in to view
@TheOneRing

This comment was marked as outdated.

Sign in to view
@HanaGemela

This comment was marked as outdated.

Sign in to view
@TheOneRing
Copy link
Contributor

TheOneRing commented Mar 31, 2023 •
edited
Loading

When the client displays a sheet, the systray context menu is supposed to be disabled, so we can't trigger the login dialog.
However due to what appears to be a Qt bug, the context menu is active when the Window is minimized.
This enables us to create a second sheet on top of the wizard/about dialog and Qt appears to have a z lvl issue again.

In addition to the sysystray context menu a loin dialog triggered by invalid credentials can also trigger the widget stacking isse.

@TheOneRing
Copy link
Contributor

TheOneRing commented Mar 31, 2023 •
edited
Loading

Related: #8421
https://bugreports.qt.io/browse/QTBUG-91059

@TheOneRing TheOneRing modified the milestones: inbox, Desktop Client 4.0 Apr 4, 2023
TheOneRing added a commit that referenced this issue Apr 4, 2023
@TheOneRing
Eliminate Utility::setModal and rather call ->open() on all dialogs
b6ee17b 
Utility::setModal was also setting Qt::ApplicationModal however
it appears Qt never cared and always set Qt::WindowModal.
https://github.com/qt/qtbase/blame/4ee4fc18b4067b90efa46ca9baba74f53b54d9ec/src/widgets/dialogs/qdialog.cpp#L543

Setting Qt::Sheet is also handled in open();

Fixes: #10621
@TheOneRing TheOneRing linked a pull request Apr 4, 2023 that will close this issue
Fix modal dialogs #10656
Merged
TheOneRing added a commit that referenced this issue Apr 4, 2023
@TheOneRing
Eliminate Utility::setModal and rather call ->open() on all dialogs
a3ba083 
Utility::setModal was also setting Qt::ApplicationModal however
it appears Qt never cared and always set Qt::WindowModal.
https://github.com/qt/qtbase/blame/4ee4fc18b4067b90efa46ca9baba74f53b54d9ec/src/widgets/dialogs/qdialog.cpp#L543

Setting Qt::Sheet is also handled in open();

Fixes: #10621
TheOneRing added a commit that referenced this issue Apr 4, 2023
@TheOneRing
Eliminate Utility::setModal and rather call ->open() on all dialogs
4e7d46e 
Utility::setModal was also setting Qt::ApplicationModal however
it appears Qt never cared and always set Qt::WindowModal.
https://github.com/qt/qtbase/blame/4ee4fc18b4067b90efa46ca9baba74f53b54d9ec/src/widgets/dialogs/qdialog.cpp#L543

Setting Qt::Sheet is also handled in open();

Fixes: #10621
TheOneRing added a commit that referenced this issue Apr 4, 2023
@TheOneRing
Eliminate Utility::setModal and rather call ->open() on all dialogs
f75c5ad 
Utility::setModal was also setting Qt::ApplicationModal however
it appears Qt never cared and always set Qt::WindowModal.
https://github.com/qt/qtbase/blame/4ee4fc18b4067b90efa46ca9baba74f53b54d9ec/src/widgets/dialogs/qdialog.cpp#L543

Setting Qt::Sheet is also handled in open();

Fixes: #10621
TheOneRing added a commit that referenced this issue Apr 4, 2023
@TheOneRing
Eliminate Utility::setModal and rather call ->open() on all dialogs
6666891 
Utility::setModal was also setting Qt::ApplicationModal however
it appears Qt never cared and always set Qt::WindowModal.
https://github.com/qt/qtbase/blame/4ee4fc18b4067b90efa46ca9baba74f53b54d9ec/src/widgets/dialogs/qdialog.cpp#L543

Setting Qt::Sheet is also handled in open();

Fixes: #10621
TheOneRing added a commit that referenced this issue Apr 4, 2023
@TheOneRing
Eliminate Utility::setModal and rather call ->open() on all dialogs
5bcb74a 
Utility::setModal was also setting Qt::ApplicationModal however
it appears Qt never cared and always set Qt::WindowModal.
https://github.com/qt/qtbase/blame/4ee4fc18b4067b90efa46ca9baba74f53b54d9ec/src/widgets/dialogs/qdialog.cpp#L543

Setting Qt::Sheet is also handled in open();

Fixes: #10621
@HanaGemela HanaGemela self-assigned this Apr 5, 2023
@HanaGemela
Copy link
Contributor Author

Fixed in ownCloud 4.0.0.10576-daily20230405, mac

@TheOneRing TheOneRing mentioned this issue Oct 6, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HanaGemela HanaGemela

Labels
macOS p3-medium Normal priority QA:team Upstream issue
Projects
None yet
Milestone
Desktop Client 4.0
Development

Successfully merging a pull request may close this issue.

Fix modal dialogs owncloud/client
2 participants
@TheOneRing @HanaGemela