Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent: Same default sync folder for multiple accounts #11204

Closed
TheOneRing opened this issue Sep 13, 2023 · 2 comments · Fixed by #11364
Closed

Prevent: Same default sync folder for multiple accounts #11204

TheOneRing opened this issue Sep 13, 2023 · 2 comments · Fixed by #11364
Assignees
Labels
p3-medium Normal priority type:bug
Milestone

Comments

@TheOneRing
Copy link
Contributor

TheOneRing commented Sep 13, 2023

Steps to reproduce:

  • Add an ocis account
  • Add a second ocis account, use advanced settings and use the default sync root form the first account

Both accounts use the same syncroot and differentiate the directory names inside that syncroot:

  • root/Personal
  • root/Personal (1)

Expectations:
The client prevents the user from using the same syncroot directory, instead offering a different syncroot:

  • root/Personal
  • root (1)/Personal
@TheOneRing TheOneRing modified the milestones: Desktop 5.0, Desktop 6.0 Sep 13, 2023
@TheOneRing TheOneRing changed the title Same default sync folder for multiple accounts Prevent: Same default sync folder for multiple accounts Sep 22, 2023
@TheOneRing TheOneRing added the p3-medium Normal priority label Sep 22, 2023
@TheOneRing
Copy link
Contributor Author

We could use xattr and ntfs streams to "claim" a folder, if neither is supported for the folder we ignore it.
That way we should always be able to prevent multiple accounts from using the same default sync root.

erikjv added a commit that referenced this issue Nov 16, 2023
erikjv added a commit that referenced this issue Nov 22, 2023
erikjv added a commit that referenced this issue Nov 22, 2023
erikjv added a commit that referenced this issue Nov 23, 2023
erikjv added a commit that referenced this issue Nov 24, 2023
erikjv added a commit that referenced this issue Dec 4, 2023
erikjv added a commit that referenced this issue Dec 4, 2023
@Salipa-Gurung
Copy link
Contributor

Salipa-Gurung commented Jan 8, 2024

Tested on :
ownCloud 6.0.0.13062-daily20240108 b46134
Libraries Qt 6.6.0, OpenSSL 3.1.4 24 Oct 2023
Using virtual files plugin: wincfapi
OS: windows-10.0.19045 (build arch: x86_64, CPU arch: x86_64)
QPA: windows

Server:
Infinite Scale 4.0.5 Community and ownCloud 10.13.4 (stable)

Adding account for brian after admin's account was added Using default syncroot from the first account
Screenshot from 2024-01-08 12-05-05 Screenshot from 2024-01-08 12-07-35
Client provides different syncroot ✔️ Client prevents user from using same syncroot directory ✔️

Finish button remains clickable(does not perform any function) when error message is being displayed. ❔

cc: @erikjv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-medium Normal priority type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants