-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another unreadable error message #11412
Milestone
Comments
erikjv
added a commit
that referenced
this issue
Jan 12, 2024
Some error messages were styled in a way that is not compatible with dark mode. These have now been replaced by unstyled labels, but the warning icon is shown to the left of the message. Fixes: #11412
This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days. |
erikjv
added a commit
that referenced
this issue
Jan 19, 2024
Some error messages were styled in a way that is not compatible with dark mode. These have now been replaced by unstyled labels, but the warning icon is shown to the left of the message. Fixes: #11412
TheOneRing
pushed a commit
that referenced
this issue
Jan 30, 2024
Some error messages were styled in a way that is not compatible with dark mode. These have now been replaced by unstyled labels, but the warning icon is shown to the left of the message. Fixes: #11412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After fixing issue #11243 , we found three more places with styled error messages. Two are in legacy dialogs (and accidentally are actually readable), but the third is a problem. This is in the
folderwizardtargetpage.ui
:It is the selected label which reads "Placeholder text", a white text on a yellow background.
One way to fix this is to do the same as in the log browser UI:
The question is if we want the red text or un-styled text, and if the latter is the case, if we want to change the log browser UI too.
The text was updated successfully, but these errors were encountered: