Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another unreadable error message #11412

Closed
erikjv opened this issue Nov 30, 2023 · 3 comments · Fixed by #11470
Closed

Another unreadable error message #11412

erikjv opened this issue Nov 30, 2023 · 3 comments · Fixed by #11470
Milestone

Comments

@erikjv
Copy link
Collaborator

erikjv commented Nov 30, 2023

After fixing issue #11243 , we found three more places with styled error messages. Two are in legacy dialogs (and accidentally are actually readable), but the third is a problem. This is in the folderwizardtargetpage.ui:

Screenshot 2023-11-30 at 18 12 09

It is the selected label which reads "Placeholder text", a white text on a yellow background.

One way to fix this is to do the same as in the log browser UI:

Screenshot 2023-11-30 at 18 09 13

The question is if we want the red text or un-styled text, and if the latter is the case, if we want to change the log browser UI too.

@TheOneRing
Copy link
Contributor

image

erikjv added a commit that referenced this issue Jan 12, 2024
Some error messages were styled in a way that is not compatible with
dark mode. These have now been replaced by unstyled labels, but the
warning icon is shown to the left of the message.

Fixes: #11412
Copy link

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 19, 2024
@TheOneRing TheOneRing added this to the Desktop 6.0 milestone Jan 19, 2024
erikjv added a commit that referenced this issue Jan 19, 2024
Some error messages were styled in a way that is not compatible with
dark mode. These have now been replaced by unstyled labels, but the
warning icon is shown to the left of the message.

Fixes: #11412
@TheOneRing TheOneRing removed the Stale label Jan 26, 2024
TheOneRing pushed a commit that referenced this issue Jan 30, 2024
Some error messages were styled in a way that is not compatible with
dark mode. These have now been replaced by unstyled labels, but the
warning icon is shown to the left of the message.

Fixes: #11412
@saw-jan
Copy link
Member

saw-jan commented Mar 28, 2024

Tested on ownCloud 6.0.0.13582-daily20240327 [4258b6]

Screenshot from 2024-03-28 15-40-51 Screenshot from 2024-03-28 15-42-16
Screenshot from 2024-03-28 15-47-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants