[1.7.0beta4] Signing out with the desktop client doesn't hide the overlay icons.

[SergioBertolinSG]

Steps to reproduce

1. Launch the desktop app
2. The overlay icons are shown
3. Sign out

Expected behaviour

The overlay icons are not shown.

Actual behaviour

Overlay icons are shown.

Server configuration

Operating system:
(Ubuntu)

Web server:
nginx/1.4.6

Database:

PHP version:
PHP/5.5.9-1ubuntu4.4

ownCloud version: (see ownCloud admin page)
{"installed":"true","version":"7.0.3.0","versionstring":"7.0.3 RC1","edition":"enterprise"}

Are you using encryption: no

Client configuration

mac version 1.7.0beta4
windows version 1.7.0beta4

Operating system:
Mac OS 1.9.5
Windows 7

[guruz]

thanks. I had the same feeling as you in the beginning, but then @dragotin told me that they're supposed to stay because a big usage for them is seeing the sync status while being offline.

[guruz]

(Which however then might be bogus? Do we show the correct icon while logged out?)

[luciamaestro]

When you sing out overlay icons don't change, @dragotin Is it the correct behavior?

[VincentvgNn]

I think that overlay icons showing the current sync status (sync busy, sync ok, error) should not be shown when OC is not syncing, i.e. cannot update files.
My preference is:
Sign out, Quit = not syncing
Pause = not syncing
No network connection for some time (more than x minutes) = not syncing

[ogoffart]

In my opinion, icons should be shown even if you are logged out.

[VincentvgNn]

For an impression of the behavior of fixed icons defined in the desktop.ini files and dynamic overlay icons for showing the sync status, one could install Google Drive for free and share a folder with someone else.
Don't forget to inactivate the OC overlay icons and maybe some more in the registry when using Windows. The Google Drive keys should not be changed and the alphabetical ranking should bring them within the first 11 positions. Inactivate by renaming e.g. by putting a character x in front of the original names and reboot, see #2487.

[dragotin]

I think if the client signs out, the overlay icons should still be visible and show the status of the last sync, and the changes that happened on the local repository. For example, if a nicely synced repo goes offline, the overlay icons would show which files were changed locally and need sync. Of course, that does not include changes from the remote repo, as there is no connection.

@MTRichards , @jancborchardt do you agree?

[VincentvgNn]

When I see a sync status, then I expect that it is correct. The history of the sync status after disconnecting from the server can have a mismatch with the current server situation.
As a user I would be misled if I would see "Sync OK" when there is no server connection for a (long) while.
If the user is changing files off-line, it may nice to see which files were locally changed. But the most important information to see that there is no sync at all. So no overlay icons showing all OK.
The "Error" overlay icons could be maintained in the off-line situation, indicating that there was an error or that the user introduced an sync error by changing files.

How do other cloud sharing systems show this?

[ogoffart]

It is correct, "Sync OK" means that the local file has been properly sync'ed and the "need sync" icon means it is not.

[jancborchardt]

I completely agree with @dragotin’s comment #2349 (comment)

Just not showing the icons is a very bad idea because it removes all feedback. The current behavior is by design.

[VincentvgNn]

@jancborchardt
"By design"?
At #1818 @MTRichards wrote on May 27th 2014:

If the system is offline, there are no overlay icons present. BUT if a file has unsynced changes, the circular (static) icon remains as long as the system is offline indicating it is waiting to sync. Then it gets a circular icon spinning once it starts syncing when the system is online.

Did the design specification change?

[dragotin]

It has changed in the way that we also show the ok-icon. I still think its ok.

[VincentvgNn]

@dragotin
Google Drive, OneDrive, Dropbox, ........, all do not show a sync icon when offline.
Why does ownCloud want to be the "only one" showing "sync OK" when being offline?

The user needs to know the current sync status and expects to see that.