Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Add icon (from owncloud.exe) to explorer favorites shortcut in Windows 7-8.1 created via installer #2446

Closed
pierrejochem opened this issue Nov 5, 2014 · 1 comment
Closed

Proposal: Add icon (from owncloud.exe) to explorer favorites shortcut in Windows 7-8.1 created via installer #2446

pierrejochem opened this issue Nov 5, 2014 · 1 comment
Labels
Design & UX Enhancement
Milestone
2.4.0

Comments

@pierrejochem
Copy link

pierrejochem commented Nov 5, 2014 •
edited by SamuAlfageme
Loading

Proposal:
Add icon (from owncloud.exe) to explorer favorites shortcut in Windows 7-8.1 created via installer.

Currently it is only the default folder icon.
@AnrDaemon
Copy link

I'd rather prefer some combnation of the two icons.
But aye, something more telling definitely needed.

@SamuAlfageme SamuAlfageme mentioned this issue Dec 13, 2016
Closed
jturcotte added a commit that referenced this issue Aug 11, 2017
@jturcotte
Windows: Use the application icon for the sidebar
793a7f6 
By setting the icon in Desktop.ini of the root folder, this adds the icon
both when browsing the folder directly and to the sidebar shortcut.

To avoid overwriting any user setting that could exist in Desktop.ini,
only do this if the file doesn't exist. Editing .ini files on Windows
isn't trivial and isn't worth it given that this file won't exist most
of the time.

Fixes #2446
This was referenced Aug 11, 2017
Merged
Closed
jturcotte added a commit that referenced this issue Aug 14, 2017
@jturcotte
Windows: Use the application icon for the sidebar
95b6264 
By setting the icon in Desktop.ini of the root folder, this adds the icon
both when browsing the folder directly and to the sidebar shortcut.

To avoid overwriting any user setting that could exist in Desktop.ini,
only do this if the file doesn't exist. Editing .ini files on Windows
isn't trivial and isn't worth it given that this file won't exist most
of the time.

Fixes #2446
jturcotte added a commit that referenced this issue Aug 15, 2017
@jturcotte
Windows: Use the application icon for the sidebar
251f1d0 
By setting the icon in Desktop.ini of the root folder, this adds the icon
both when browsing the folder directly and to the sidebar shortcut.

To avoid overwriting any user setting that could exist in Desktop.ini,
only do this if the file doesn't exist. Editing .ini files on Windows
isn't trivial and isn't worth it given that this file won't exist most
of the time.

Fixes #2446
@guruz guruz added this to the 2.4.0 milestone Aug 15, 2017
jturcotte added a commit that referenced this issue Sep 11, 2017
@jturcotte
Windows: Make sure that the folder and Desktop.ini have the right att…
44d255a 
…ributes

When created from scratch, the owncloud icon won't be picked-up by
explorer unless the right attributes are set on both the sync root and the
Desktop.ini file.

Issue #2446
@jturcotte jturcotte mentioned this issue Sep 11, 2017
Merged
jturcotte added a commit that referenced this issue Sep 11, 2017
@jturcotte
Windows: Make sure that the folder and Desktop.ini have the right att…
2d7a4bd 
…ributes (#6018)

When created from scratch, the owncloud icon won't be picked-up by
explorer unless the right attributes are set on both the sync root and the
Desktop.ini file.

Issue #2446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design & UX Enhancement
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
5 participants
@guruz @SamuAlfageme @luciamaestro @AnrDaemon @pierrejochem