[Windows] Fix sqlite3 for sync folders on FAT(?) permissions

[guruz]

We need to find out if WAL (that was activated for 1.7.0) is a problem and we'd need to detect FAT(?) or if there is another way.

Related:

• ownCloud client 1.7.1 won't sync files on exfat drive #2693
• CSync failed to load or create the journal file - SQlite error? #2673

"On Windows, Microsoft's documentation says that locking may not work under FAT filesystems if you are not running the Share.exe daemon. " https://www.sqlite.org/faq.html
A question is if setting the lock mode helps: https://www.sqlite.org/draft/pragma.html#pragma_locking_mode https://www.sqlite.org/draft/wal.html#noshm (according to someone on IRC in #sqlite no..)

I propose that for now when creating a new Journal, we'll use GetVolumeInformationW (http://msdn.microsoft.com/en-us/library/aa364993(v=vs.85).aspx) and check lpFileSystemNameBuffer if it contains ntfs. If not, then we don't enable WAL.

[ogoffart]

I could not reproduce the problem with master and a FAT partition.

[guruz]

Are you using Windows 8.1 like the other reporters?

[guruz]

@ogoffart The reporter in #2693 mentions exFAT..

[ckamm]

Here are also two reports of issues with exFAT and sqlite:
http://stackoverflow.com/questions/13798826/android-sqlite-crash-with-exfat-filesystem
http://forum.xojo.com/13737-sqlite-table-on-exfat-file-system/0

[ckamm]

I tried with an exfat-formatted USB stick from linux and that worked fine. I will attempt the same from Windows later.

[ckamm]

I could not reproduce the issue when syncing an owncloud folder to an exFAT-formatted USB stick in a Windows 7 guest.

[ckamm]

@danimo and me just tried with exfat and Windows 8.1 and couldn't reproduce it either. Any other ideas?

[guruz]

@dragotin Shall we have Windows specific code that adds a special message when this error happens that we don't support exfat?
Alternatively we can add a message in the "Add folder" wizard.

@rudo54 and @andrewbridge had this issue, so at least for them it existed..

[ckamm]

@guruz I'm not convinced it's related to the WAL file, look at @andrewbridge's log in #2693. Maybe the DB really is corrupt - or there's a bug in quick_check on exFAT somehow?

[guruz]

Yes, I'm not convinced anymore either. It's just that it happened with 1.7.0

1. updating the sqlite3 version
2. when enabling WAL

@dragotin close issue?

[dragotin]

yes, I think we can close this one, as the investigations haven't lead to something. And we also remove the corrupted file so it gets recreated so I think its done.

[guruz]

(Although I remember one of the reporters mentioned having recreated the DB, tried a new sync dir etc..odd)

[soluxima-erik]

I know this is closed, but I could not find a solution in any of the posts. I have the following setup:

• Windows 10 (64)
• Latest OC client 2.1.0 (build 5683)
• Mounted exFAT drive as target (encrypted volume by DiskCryptor)

But I get the same result as what started this thread, seams to be a locking issue.

Was the consensus just to not use exFAT target drives?

[guruz]

Have you also tried to contact DiskCryptor about this?

Does removing the .csync_journal* files change anything?

[soluxima-erik]

@guruz
Yes, they said its standard exFAT partition with all permissions open. I tried with a standard exFAT partition (not spawned from DiskCryptor) and the same thing happens.
No, removing any of the files fixes nothing. A new file is made by the client with the same error.

For the record, selecting a directory in the standard NTFS partition works fine, the client works flawlessly as it should. Its just the exFAT partitions providing the spanner in the works.

[guruz]

@soluxima-erik Could you run with a logfile (see the manual on how to do that) and see if you get the log message 5cdf448#diff-0b6f105ffd4493a278873f32b7c170c1R116

FYI @ckamm

[AMDG2]

I get the same problem today. Here is my setup :

• Windows 10 (32)
• Owncloud (2.1.0, build 5683, git rev. c0c9fb3)
• Installed on SD-Card
• Sync folder on SD-Card
• SD-Card format: exFat

Here is my log: (removed by @guruz)

[guruz]

01-15 18:42:37:456 0x49a7cc0 OCC::SqlQuery::prepare: Sqlite prepare statement error: "disk I/O error" in "PRAGMA quick_check;"
01-15 18:42:37:456 0x49a7cc0 OCC::SqlDatabase::checkDb: quick_check returned failure: ""
01-15 18:42:37:456 0x49a7cc0 OCC::SqlDatabase::openOrCreateReadWrite: Consistency check failed, removing broken db "D:/baudouin/owncloud/.csync_journal.db"
01-15 18:42:37:471 0x49a7cc0 OCC::SyncJournalDb::checkConnect: sqlite3 version "3.9.1"
01-15 18:42:37:471 0x49a7cc0 OCC::SqlQuery::prepare: Sqlite prepare statement error: "disk I/O error" in "PRAGMA journal_mode=WAL;"

@AMDG2 Does it work when you set the OWNCLOUD_SQLITE_JOURNAL_MODE environment variable to DELETE when launching oC client?

[AMDG2]

Yes it works. I tried to delete csync journal from Owncloud sync folder before but it doesn't work. Was it an error ?

May I help to fix the issue in Owncloud Client ?

[guruz]

@AMDG2 We'll give you a new build next week to try. Something is wrong with the FAT detection.
Please stay tuned :)

[ckamm]

@guruz This might be a bug in the file system detection function:

QString drive = path.left(3);
if (! drive.endsWith(":\\"))
    return QString();

In the log, the path is "D:/..." so / vs \.

[ckamm]

@AMDG2 A potential fix is in 2.1 (it didn't make it into beta1). Could you try a new nightly from http://download.owncloud.com/desktop/daily/ tomorrow?

[AMDG2]

I will try it in the evening (GMT+2) or tomorrow.
I let you know :)

Le 19 janvier 2016 10:03:16 GMT+01:00, ckamm notifications@github.com a écrit :

@AMDG2 A potential fix is in 2.1 (it didn't make it into beta1).
Could you try a new nightly from
http://download.owncloud.com/desktop/daily/ tomorrow?

---

Reply to this email directly or view it on GitHub:
#2701 (comment)

Envoyé de mon appareil Android avec K-9 Mail. Veuillez excuser ma brièveté.

[ZarekParker]

I upgraded to ownCloud 8.2.0 server a while back and this issue started happening - I was no longer able to sync due to the csync error. Tonight I downloaded ownCloud-2.1.1.5785-nightly20160120-setup.exe. After uninstall of my previous version and an installation of the new version, ownCloud popped up and started syncing immediately. I am unfortunately getting 'Service Unavailable'...'Operation Canceled' errors upon sync, which may be an unrelated issue.

[guruz]

@XianPalin Sounds unrelated. Please try 8.2.1, if issue persists create a new issue.

[guruz]

@AMDG2 http://download.owncloud.com/desktop/daily/ownCloud-2.1.1.5785-nightly20160120-setup.exe @soluxima-erik

[Dianafg76]

@AMDG2 Could you try this: ownCloud-2.1.1.3067-nightly20160125.pkg, please?

[AMDG2]

@guruz this version was working. I didn't have time to try your version @Dianafg76

[guruz]

👍