Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OS X] Add link to sync folder with ownCloud icon in Finder Sidebar #296

Closed
rgr101 opened this issue Jan 30, 2013 · 17 comments
Closed

[OS X] Add link to sync folder with ownCloud icon in Finder Sidebar #296

rgr101 opened this issue Jan 30, 2013 · 17 comments
Assignees
Milestone

Comments

@rgr101
Copy link

rgr101 commented Jan 30, 2013

Just a nice-to-have with no priority:

Have an Owncloud icon instead of the ordinary folder icon in Finder's Sidebar
(just like Dropbox does).


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@alexschomb
Copy link

Same topic for SparkleShare. No solution yet. hbons/SparkleShare#503

@davidak
Copy link
Member

davidak commented Mar 19, 2013

Yes, this would be nice and give the "normal" users even more the good dropbox feeling.

@ghost ghost assigned danimo Mar 25, 2013
@jorgelbg
Copy link

Is there any work done on this issue?

@guruz
Copy link
Contributor

guruz commented Feb 4, 2014

No work done yet as far as I know.
It's a bit hacky because it can only be done by code injection.
See http://apple.stackexchange.com/a/83288/58458

@guruz
Copy link
Contributor

guruz commented Sep 12, 2014

1.7 related update: For the Finder overlay icons in 1.7 we now have code injected into Finder. It is possibly easier now to integrate this.

https://github.com/owncloud/mirall/tree/1.7/shell_integration/MacOSX/OwnCloudFinder

@jorgelbg
Copy link

WOW! this is wonderfull is already available for download?

On 9/12/14, Markus Goetz notifications@github.com wrote:

1.7 related update: For the Finder overlay icons in 1.7 we now have code
injected into Finder. It is possibly easier now to integrate this.

https://github.com/owncloud/mirall/tree/1.7/shell_integration/MacOSX/OwnCloudFinder


Reply to this email directly or view it on GitHub:
#296 (comment)

@danimo danimo modified the milestones: 1.9 - Multi-account, 1.8 - UI Enhancements Jan 19, 2015
@guruz guruz assigned jturcotte and unassigned danimo Jun 12, 2015
@jturcotte
Copy link
Member

I looked at how to do this in relation with #2340, there is an official way documented within the FinderSync doc in the "Adding a Sidebar icon":
https://developer.apple.com/library/mac/documentation/General/Conceptual/ExtensibilityPG/Finder.html#//apple_ref/doc/uid/TP40014214-CH15

This seems to rely on the FinderSync watched folder list (I didn't try yet) but fetches the icon from the wrapping application's own CFBundleIconFile .icns file. We'd need to replace the manual kdelibs logic in cmake/modules/AddAppIconMacro.cmake with an .iconset folder (containing extra sidebar_123x123.png files) and generate the .icns using iconutils instead.

The main problem I see with this though is that I'd have to change the structure of all the branding repository which fetches those files or create this .iconset directory on the fly in the build directory. I'm not sure yet if that amount of work is worth showing a fancier icon in the Finder sidebar, what do you think?

@rgr101
Copy link
Author

rgr101 commented Jun 19, 2015

I strongly believe this is an important part of visibility and brand generation, and so it'll be worth the efforts by sure...

@jorgelbg
Copy link

This little features creates a lot of user value (from my point of
view) mainly due the fact that increases the integration between the
application and the user environment.

On 6/19/15, rgr101 notifications@github.com wrote:

I strongly believe this is an important part of visibility and brand
generation, and so it'll be worth the efforts by sure...


Reply to this email directly or view it on GitHub:
#296 (comment)

@guruz guruz modified the milestones: 2.1-next, 2.0 - Multi-account Jul 29, 2015
@guruz guruz assigned MTRichards and unassigned jturcotte Jul 29, 2015
@guruz
Copy link
Contributor

guruz commented Jul 29, 2015

@MTRichards @jancborchardt Please also discuss with regards to multi-account or multiple sync folders.
And see @jturcotte 's comment above.

@jancborchardt
Copy link
Member

For multi-account, I’d say every local folder should have an entry in the sidebar. For multiple sync folders, not sure.

@MTRichards
Copy link

For multi-account, I’d say every local folder should have an entry in the sidebar.

Yes, each root folder should get a shortcut on the finder menu, and in windows in explorer.

For multi account, the rule remains that root sync folders get left menu icons - but only one. So if a root folder is synced in two accounts, only 1 sidebar as it is the same folder.
If the root and a sub folder are synced to two different accounts, then that is like having 2 root folders, so two icons on the left.

@jancborchardt what do you think?

@jancborchardt
Copy link
Member

@MTRichards sounds reasonable, yes.

@MTRichards
Copy link

Ok. Confirming 2.1 as the milestone then.

@guruz guruz modified the milestones: 2.2-next, 2.1-next Nov 3, 2015
@Ark74
Copy link

Ark74 commented Jan 26, 2016

Hi!, i see that this is an OSX related issue. Is there a Windows related one or i could be informed by watching this?

@guruz guruz removed the blue-ticket label Mar 4, 2016
@guruz guruz removed this from the 2.2.0-current milestone Mar 4, 2016
@guruz guruz changed the title OSX: Owncloud icon in Finder Sidebar [OS X] Add link to sync folder with ownCloud icon in Finder Sidebar Mar 4, 2016
@guruz guruz added this to the 2.4.0 milestone Mar 29, 2017
@guruz guruz assigned guruz and jturcotte and unassigned MTRichards and guruz Mar 29, 2017
@guruz
Copy link
Contributor

guruz commented Apr 5, 2017

(At least currently the code to create a sidebar favorite seems not to be called at all because it is in a not possible anymore else branch.. check the wizard for Utility::setupFavLink( localFolder ))

@guruz guruz modified the milestones: 2.5.0, 2.4.0 Jun 14, 2017
jturcotte added a commit to jturcotte/owncloud-client that referenced this issue Jul 31, 2017
In the process, use an iconset to generate the icns using iconutil.
Also add some missing icon resolutions according to the guidelines.

Issue owncloud#296
@guruz
Copy link
Contributor

guruz commented Jul 31, 2017

Some progress: #5928 (comment)
\o/

jturcotte added a commit that referenced this issue Jul 31, 2017
In the process, use an iconset to generate the icns using iconutil.
Also add some missing icon resolutions according to the guidelines.

Issue #296
@guruz guruz modified the milestones: 2.5.0, 2.4.0 Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests