[SSL] Investigate if we really use Session Tickets

[guruz]

Started here but got sidetracked, will continue next time.
We need this because we want to save roundtrips when establishing connections (this is temporarily until we can have SPDY/HTTP2 (#3146)

diff --cc src/libsync/accessmanager.cpp
index 331f9d0,331f9d0..e6b34fb
--- a/src/libsync/accessmanager.cpp
+++ b/src/libsync/accessmanager.cpp
@@@ -63,6 -63,6 +63,8 @@@ QNetworkReply* AccessManager::createReq
  {
      QNetworkRequest newRequest(request);

++    newRequest.setRawHeader("Connection", "Close");
++
      if (newRequest.hasRawHeader("cookie")) {
          // This will set the cookie into the QNetworkCookieJar which will then override the cookie header
          setRawCookie(request.rawHeader("cookie"), request.url());
diff --cc src/libsync/account.cpp
index 9b8941f,9b8941f..5de75de
--- a/src/libsync/account.cpp
+++ b/src/libsync/account.cpp
@@@ -383,6 -383,6 +383,9 @@@ QSslConfiguration Account::createSslCon
          qDebug() << "Added SSL client certificate to the query";
      }

++    qDebug() << "ALLOWING REUSE HERE";
++    sslConfig.setSslOption(QSsl::SslOptionDisableSessionTickets, false);
++
      return sslConfig;
  }

diff --cc src/libsync/networkjobs.cpp
index 7e92d96,7e92d96..94a264f
--- a/src/libsync/networkjobs.cpp
+++ b/src/libsync/networkjobs.cpp
@@@ -26,6 -26,6 +26,7 @@@
  #include <QMutex>
  #include <QDebug>
  #include <QCoreApplication>
++#include <QSslConfiguration>

  #include "json.h"

@@@ -507,6 -507,6 +508,10 @@@ void LsColJob::start(
  // not in all in one big blobb at the end.
  bool LsColJob::finished()
  {
++    QSslConfiguration conf = reply()->sslConfiguration();
++    qDebug() << "SSL TICKET:" << reply()->sslConfiguration().sessionTicket();
++
++
      QString contentType = reply()->header(QNetworkRequest::ContentTypeHeader).toString();
      int httpCode = reply()->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
      if (httpCode == 207 && contentType.contains("application/xml; charset=utf-8")) {

[guruz]

There is two parts to this
One is we need

sslConfig.setSslOption(QSsl::SslOptionDisableSessionTickets, false);
sslConfig.setSslOption(QSsl::SslOptionDisableSessionSharing, false);
sslConfig.setSslOption(QSsl::SslOptionDisableSessionPersistence, false);

The other one is that it looks like the QSslConfig creation in #3027 overrides something all the time so the session ticket is not reused.

Let's see..

FYI @peter-ha @danimo

[peter-ha]

IIRC you only need

sslConfig.setSslOption(QSsl::SslOptionDisableSessionPersistence, false);

At least session sharing should be enabled by default...

[guruz]

Done, it should nag now with a warning if the SSL session is not reused.

FYI @ckamm @dragotin @danimo

[Dianafg76]

@guruz I need information on what I need to test
Thanks