[Overlays] Client folder error status not shown in higher-level icon status #3634

phil-davis · 2015-08-17T09:40:17Z

Expected behaviour

If a folder has a problem syncing from client to server then the problem status will be shown in the icons of parent folders and in the overall sync status icon in the icon box.

Actual behaviour

If a folder has a problem syncing from client to server it (correctly) shows a little red "x" in the folder icon.
But any folders above it show green,
The overall client status icon shows green.

If the problem folder is several folders down in the folder tree then the user is unlikely to notice it and thus will not know to investigate.

It would be nice to show some non-green status for the folders above and the overall status icon.

Steps to reproduce

On the client create FolderA.
Let it sync up to the server.
From the folders-to-sync dropdown, unselect FolderA and apply.
A sync starts, FolderA is deleted on the client - good - and remains on the server - good.
Create another FolderA in the same place.
FolderA is shown with red "x" icon - good.
Activity log says: Ignored because of the "choose what to sync" blacklist
That is also reasonable, because there is already FolderA on the server with some (presumably different) content, and it is not being synced to this client.

But the overall sync status is green.

There is the same sort of behaviour when FolderA is inside some other folder/s. The higher level folders all show green status.

Server configuration

ownCloud version: 8.0

Client configuration

Client version: Version 2.0.0-nightly20150817 (build 5403)

Operating system: Windows 10

OS language: English (US)

Installation path of client: default

MTRichards · 2015-08-18T18:45:12Z

@guruz are you working on this now for 2.0, or does it slide to 2.0.1?

jturcotte · 2015-08-18T19:42:09Z

I haven't investigated it yet but unless this is a regression from 1.8 (it's not, is it?) then we shouldn't put pressure on 2.0.0. If this requires bigger changes it might have to go in 2.1.

See also #3171 for a glimpse of how error statuses aresn't preserved as long as they should. The moment that a file ends up in the black list, its status becomes invisible to the user. My knowledge of that area isn't quite good though, @ogoffart could prove me wrong if I am.

jturcotte · 2015-08-18T19:59:08Z

Another question is: Is it correct to propagate anything else than the SYNC status to parent folders?

If I have the structure:
A
|- B
|- C

And that C has an ignored or error status, should A also be marked as ignored/error? A isn't ignored completely, A isn't completely in error either. For SYNC, however we can say that "A isn't up-to-date", implied by C not being up-to-date.

I agree that there should be a way to see the error more easily than by inspecting the activity monitor, but I'm not sure if the status of parent directories is the right place to keep that information until the user decides to fix the situation (if he even knows how to fix it). It might handicap his ability to quickly judge if other files are up-to-date. Let me know how you see it.

MTRichards · 2015-08-18T21:20:26Z

I thought we said that A should have a yellow, saying that it was non fatal, but there were problems in the directory below it. If the entire directory in C failed, C is red, otherwise if it is a partial fail C is yellow too, and that gets propagated up. I have to find the selective sync notes as it outlines it.

MTRichards · 2015-08-18T21:22:34Z

Found it:
#1818
That has the details on the design point for folders, including errors.

phil-davis · 2015-08-19T01:50:20Z

Those requirements look good, with the addition of the "bubbling up with yellow" to parent folders that have red somewhere below but not all red, as @MTRichards has commented.

dragotin · 2015-08-21T10:31:09Z

Moved to 2.1. This is not exactly how it is implemented today and as a result a bigger change.

dragotin · 2015-08-21T10:33:00Z

This should be done together with #3171

guruz · 2016-01-04T12:06:57Z

Related #4026

…t folders #3634 This also remove all smartness from the SocketApi about the status of a file and solely use info from the current and last sync. This simplifies the logic a lot and prevents any discrepancy between the status shown in the activity log and the one displayed on the overlay icon of a file. The main benefit of the additional simplicity is that we are able to push all new status of a file reliably (including warnings for parent folders) to properly update the icon on overlay implementations that don't allow us invalidating the status cache, like on OS X. Both errors and warning from the last sync are now kept in a set, which is used to also affect parent folders of an error. To make sure that errors don't become warning icons on a second sync, SyncFileItem::_hasBlacklistEntry is also interpreted as an error. This also renames StatusIgnore to StatusWarning to match this semantic. SyncEngine::aboutToPropagate is used in favor of SyncEngine::syncItemDiscovered since the latter is emitted before file permission warnings are set on the SyncFileItem. SyncEngine::finished is not used since we have all the needed information in SyncEngine::itemCompleted.

guruz · 2016-04-06T12:41:37Z

@phil-davis Can re-test this with a recent nightly as soon as the overlay binaries are rebuilt (#4631)

guruz · 2016-04-07T13:49:04Z

@phil-davis Would you re-test this? :)
http://download.owncloud.com/desktop/daily/ownCloud-2.2.0.5976-nightly20160407-setup.exe

guruz · 2016-04-19T12:50:37Z

@phil-davis Still alive? :-)
There's even newer nightlies now..

mcastroSG · 2016-04-19T14:43:02Z

Hi hi:

@guruz I have made some test about this Issue using basically the same steps that @phil-davis put:

Steps executed

On the client create Folder1.
Inside Folder1 create Folder2
Let it sync up to the server.
From the folders-to-sync dropdown, unselect Folder2 and apply.
A sync starts, Folder2 is deleted on the client and still is on the server.
Create another Folder2 in the same place.

Results:

Folder2 is shown with yellow icon and Activity log says: Ignored because of the "choose what to sync" blacklist, but Folder1 remains with a green icon.So it seems that sync error are not getting propagated up .

MacOS
Client Version: Version 2.2.0-nightly20160419 (build 3282)
Client OS: MacOS X El Capitan 10.11.4
Server Version: 9.0.1
Server OS: Ubuntu

Unable to check it on windows due to https://github.com/owncloud/client/issues/4701

Regards

jturcotte · 2016-04-19T15:17:48Z

Warning don't get propagated up, only errors. Else the root folder for example would never be green, there is always an ignored file somewhere in the tree (for example the .csync_journal db) and the user most likely won't want to change this. Errors on the other hand will usually need to be actioned by the user.

jturcotte · 2016-04-19T15:19:41Z

Maybe the "ignored because of the choose what to sync blacklist" message should be an error though, it's not a normal use case.

guruz · 2016-04-22T13:14:32Z

@mcastroSG BTW, the overlays are very OS-sensitive. So in this case you should test Windows (where @phil-davis is on).
The spec that @jturcotte mentions is https://github.com/owncloud/client/pull/4704/files ..

mcastroSG · 2016-04-26T11:20:16Z

Blocked due to #4737

mcastroSG · 2016-05-05T12:58:27Z

Hi hi:

Test Case ID	Test case	Steps	Expected behaviour	Result
1	Overlay Icons - Folder hierarchy warning	1.- Generate a warning i.e a folder that could not be synced	Overlay icon at parent folder is a "Green check"	✅
2	Overlay Icons - Folder hierarchy error	1.- Generate an error i.e exceed quota allowed	Overlay icon at parent folder is "Yellow warning" icon	✅
3	Overlay Icons - Folder hierarchy error solved	1.- Generate an error i.e exceed quota allowed 2.- Wait till error is returned 3.- Solve problem deleting problematic files	Overlay icon at parent folder is updated from "Yellow warning" icon to "Green Check" icon	✅

OSX:

Client OS: OS X El capitán 10.11.4
Client Version: Version 2.2.0-nightly20160504 (build 3331)

OSW:

Client OS: W81
Client Version: Version 2.2.0-nightly20160505 (build 6054)
OSLinux

Client OS: Ubuntu 14.04 LTE
Client Version: Version 2.2.0nightly201654 (build 1587)

guruz assigned jturcotte Aug 17, 2015

guruz added this to the 2.0 - Multi-account milestone Aug 17, 2015

guruz added the type:bug label Aug 17, 2015

MTRichards modified the milestones: 2.0.1-next, 2.0 - Multi-account Aug 18, 2015

MTRichards modified the milestones: 2.0 - Multi-account, 2.0.1-next Aug 18, 2015

dragotin modified the milestones: 2.1-next, 2.0 - Multi-account Aug 21, 2015

phil-davis mentioned this issue Aug 24, 2015

Unchecking synchronized subfolder without local delete #2502

Open

guruz unassigned jturcotte Oct 20, 2015

guruz changed the title ~~Client folder error status not shown in higher-level icon status~~ [Overlays] Client folder error status not shown in higher-level icon status Oct 20, 2015

guruz changed the title ~~[Overlays] Client folder error status not shown in higher-level icon status~~ [Windows] [Overlays] Client folder error status not shown in higher-level icon status Nov 3, 2015

guruz modified the milestones: 2.1.2, 2.1-next Nov 3, 2015

guruz assigned jturcotte Jan 5, 2016

jturcotte modified the milestones: 2.2-next, 2.1.1-current Jan 11, 2016

jturcotte changed the title ~~[Windows] [Overlays] Client folder error status not shown in higher-level icon status~~ [Overlays] Client folder error status not shown in higher-level icon status Mar 28, 2016

guruz added the ReadyToTest QA, please validate the fix/enhancement label Apr 6, 2016

guruz removed the ReadyToTest QA, please validate the fix/enhancement label Apr 6, 2016

guruz unassigned jturcotte Apr 6, 2016

guruz added the ReadyToTest QA, please validate the fix/enhancement label Apr 7, 2016

guruz added the sev2-high label Apr 19, 2016

guruz removed the ReadyToTest QA, please validate the fix/enhancement label Apr 19, 2016

dragotin mentioned this issue Apr 19, 2016

SyncFileStatusTracker: Add a method to handle the root item. #4689

Merged

guruz added the ReadyToTest QA, please validate the fix/enhancement label Apr 22, 2016

mcastroSG added the Waiting label Apr 26, 2016

mcastroSG removed the Waiting label Apr 27, 2016

mcastroSG closed this as completed May 5, 2016

mcastroSG removed the ReadyToTest QA, please validate the fix/enhancement label May 5, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Overlays] Client folder error status not shown in higher-level icon status #3634

[Overlays] Client folder error status not shown in higher-level icon status #3634

phil-davis commented Aug 17, 2015

MTRichards commented Aug 18, 2015

jturcotte commented Aug 18, 2015

jturcotte commented Aug 18, 2015

MTRichards commented Aug 18, 2015

MTRichards commented Aug 18, 2015

phil-davis commented Aug 19, 2015

dragotin commented Aug 21, 2015

dragotin commented Aug 21, 2015

guruz commented Jan 4, 2016

guruz commented Apr 6, 2016

guruz commented Apr 7, 2016

guruz commented Apr 19, 2016

mcastroSG commented Apr 19, 2016 •

edited

Loading

jturcotte commented Apr 19, 2016

jturcotte commented Apr 19, 2016

guruz commented Apr 22, 2016

mcastroSG commented Apr 26, 2016

mcastroSG commented May 5, 2016

[Overlays] Client folder error status not shown in higher-level icon status #3634

[Overlays] Client folder error status not shown in higher-level icon status #3634

Comments

phil-davis commented Aug 17, 2015

Expected behaviour

Actual behaviour

Steps to reproduce

Server configuration

Client configuration

MTRichards commented Aug 18, 2015

jturcotte commented Aug 18, 2015

jturcotte commented Aug 18, 2015

MTRichards commented Aug 18, 2015

MTRichards commented Aug 18, 2015

phil-davis commented Aug 19, 2015

dragotin commented Aug 21, 2015

dragotin commented Aug 21, 2015

guruz commented Jan 4, 2016

guruz commented Apr 6, 2016

guruz commented Apr 7, 2016

guruz commented Apr 19, 2016

mcastroSG commented Apr 19, 2016 • edited Loading

jturcotte commented Apr 19, 2016

jturcotte commented Apr 19, 2016

guruz commented Apr 22, 2016

mcastroSG commented Apr 26, 2016

mcastroSG commented May 5, 2016

mcastroSG commented Apr 19, 2016 •

edited

Loading