Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OC9.0 will come with an additional WebDAV endpoint .... #4007

Closed
DeepDiver1975 opened this issue Oct 26, 2015 · 14 comments
Closed

OC9.0 will come with an additional WebDAV endpoint .... #4007

DeepDiver1975 opened this issue Oct 26, 2015 · 14 comments
Assignees
@ogoffart @SamuAlfageme
Labels
Enhancement ReadyToTest QA, please validate the fix/enhancement
Milestone
2.3.0

Comments

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Oct 26, 2015 •
edited by SamuAlfageme
Loading

..... which would be great if the client could make use of.

deepdiver@alien:~/Development/ownCloud/master [master]$ cadaver http://localhost:8080/remote.php/dav
Authentication required for ownCloud on server `localhost':
Username: admin
Password: 
dav:/remote.php/dav/> ls
Listing collection `/remote.php/dav/': succeeded.
Coll:   files                                  0  Okt 26 17:12
Coll:   principals                             0  Okt 26 17:12
dav:/remote.php/dav/> cd files/admin
dav:/remote.php/dav/files/admin/> ls
Listing collection `/remote.php/dav/files/admin/': succeeded.
Coll:   a b c                                  0  Okt 21 15:04
Coll:   litmus                                 0  Okt 23 12:34
Coll:   test                                   0  Okt 21 15:04
        IMG_2003.JPG                      218414  Okt  8 12:38
        IMG_2004.JPG                      238147  Okt  8 12:38
        IMG_2020.JPG                      109440  Okt  8 12:38
        IMG_2021.JPG                       92282  Okt  8 12:38
        IMG_2033.JPG                      139402  Okt  8 12:38
        IMG_2034.JPG                      261785  Okt  8 12:38
        IMG_2035.JPG                      279182  Okt  8 12:38
        IMG_2110.JPG                      107861  Okt  8 12:38
        IMG_2148.JPG                      249447  Okt  8 12:38
        IMG_2165.JPG                      208738  Okt  8 12:38
        New text file.txt                      0  Okt 12 14:04
        import.ics                        187203  Okt 12 14:03
        test-import.ics                      237  Okt 13 14:33
        welcome.txt                          163  Okt  5 17:18
dav:/remote.php/dav/files/admin/>
@DeepDiver1975
Copy link
Member Author

... more resources will come

@guruz
Copy link
Contributor

guruz commented Oct 27, 2015

Return it as part of the capabilities call then we try to favor it over the default endpoint?

@DeepDiver1975
Copy link
Member Author

Return it as part of the capabilities call then we try to favor it over the default endpoint?

In the first place I need this as a config option to some degree to start testing the endpoint.
especially on the cmd client for smashbox'ing.

The decision to enable it could be done on server version at the end from my understanding

@ogoffart
Copy link
Contributor

It can be configured in the theme already (in Theme::webDavPath). Is that enough for you?
But the best would be to put that as a property in the capabilities and then we just use that. if present.

@DeepDiver1975
Copy link
Member Author

It can be configured in the theme already (in Theme::webDavPath). Is that enough for you?

using a theme will not work because I don't want to maintain my own branded client build.
In addition there is the need to pass in the user name into the dav url.

@DeepDiver1975
Copy link
Member Author

But the best would be to put that as a property in the capabilities and then we just use that. if present.

If this helps you - sure - why not

@DeepDiver1975 DeepDiver1975 mentioned this issue Oct 27, 2015
Closed
28 tasks
@guruz guruz mentioned this issue Oct 29, 2015
Closed
@DeepDiver1975
Copy link
Member Author

Is it possible to get the dav url changed via pure configuration?

For the very first try I'd be fine if I have to explicitly set the principal name in the url - THX

@dragotin @guruz

@NvanAdrichem NvanAdrichem mentioned this issue Nov 2, 2015
Closed
@dragotin
Copy link
Contributor

dragotin commented Nov 3, 2015

The new webdav endpoint will contain the user name, or rather the principal. That is not neccessarily the user. That means that the client needs to query the principal at startup, before accessing any webdav resources.

The server provides an OCS call to query the principal.

@guruz guruz added this to the 2.2-nextminor milestone Jan 4, 2016
@guruz guruz added Enhancement p2-high Escalation, on top of current planning, release blocker labels Jan 4, 2016
@MTRichards
Copy link

Need to add to this issue:
New chunking algorithm. This new algorithm will need to be implemented in client with the new endpoint on the server. Setting to 2.2 for release roughly in time with oC 9.0.

@dragotin for additional technical details please.

@MTRichards MTRichards mentioned this issue Jan 8, 2016
Closed
3 tasks
@dragotin
Copy link
Contributor

By now, the branch with the new server implementation was not yet merged, and its not sure if it will for 9.0.
We will work on implementing against the pull request owncloud/core#20118 in the 2.2.0 codebase to enable testing the system (smashbox tests etc.).

@dragotin dragotin removed this from the 2.2.0-current milestone Feb 23, 2016
@dragotin
Copy link
Contributor

Branch is not merged, milestone removed.

@SergioBertolinSG SergioBertolinSG mentioned this issue May 18, 2016
Open
2 tasks
@dragotin dragotin added this to the 2.3.0 milestone Sep 16, 2016
@guruz
Copy link
Contributor

guruz commented Oct 14, 2016

Status: (AFAIK) Waiting for server capability returned

@guruz
Copy link
Contributor

guruz commented Oct 14, 2016

@ogoffart How is this issue vs the new chunking?
Completely seperate?

@guruz guruz mentioned this issue Nov 22, 2016
Merged
ogoffart added a commit that referenced this issue Nov 29, 2016
@ogoffart
libsync: use the new webdav url if the server reports it
a61d009 
The rules to select the webdav url are now:

 - If the server reports that the new chunking algorithm is working,
   always use remote.php/dav/files/<username>
   This capability can be overriden with an environment variable

 - Otherwise, use the dav path provided by the theme, which defaults to
   remote.php/webdav

This means that with the newer server, the branding can no longer override
the webdav URL. If there is still an usecase for the branding to do so, we
need to find another way to override it. But it is now more complicated to
configure as might need include the username and need different endpoint
depending on the operations (chunks or not)

Issue #4007
ogoffart added a commit that referenced this issue Nov 29, 2016
@ogoffart
libsync: use the new webdav url if the server reports it
19d2677 
The rules to select the webdav url are now:

 - If the server reports that the new chunking algorithm is working,
   always use remote.php/dav/files/<username>
   This capability can be overriden with an environment variable

 - Otherwise, use the dav path provided by the theme, which defaults to
   remote.php/webdav

This means that with the newer server, the branding can no longer override
the webdav URL. If there is still an usecase for the branding to do so, we
need to find another way to override it. But it is now more complicated to
configure as might need include the username and need different endpoint
depending on the operations (chunks or not)

Issue #4007
@guruz guruz added ReadyToTest QA, please validate the fix/enhancement and removed p2-high Escalation, on top of current planning, release blocker labels Nov 30, 2016
@guruz
Copy link
Contributor

guruz commented Nov 30, 2016

#5332 has been merged.
@SamuAlfageme This is about testing with new endpoint on the new server version.

@SamuAlfageme SamuAlfageme self-assigned this Dec 27, 2016
This was referenced Jan 30, 2017
Closed
Closed
@davigonz davigonz mentioned this issue Feb 6, 2017
Closed
@guruz guruz closed this as completed Mar 16, 2017
This was referenced Jan 9, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogoffart ogoffart

@SamuAlfageme SamuAlfageme

Labels
Enhancement ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
6 participants
@ogoffart @guruz @DeepDiver1975 @dragotin @MTRichards @SamuAlfageme