Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OS X] [2.1.0] Local files are read-only regardless of permissions on server #4450

Closed
jrtilson opened this issue Feb 9, 2016 · 13 comments
Closed
Assignees
Labels
ReadyToTest QA, please validate the fix/enhancement type:bug
Milestone

Comments

@jrtilson
Copy link

jrtilson commented Feb 9, 2016

Expected behaviour

Files with 'can edit' permissions are writable locally by user

Actual behaviour

Files are all read-only

Steps to reproduce

  1. ownCloud user has access to shared folder, with can edit permissions
  2. Install/open owncloud client for the first time
  3. Set server url and authenticate
  4. Accept all defaults (sync everything)
  5. Sync begins
  6. Files are read-only
pwd
/Users/user/ownCloud/Shared/Technology
ls -lha
total 8
drwxr-xr-x  3 user  staff   102B  9 Feb 14:18 ./
drwxr-xr-x  4 user  staff   136B  9 Feb 14:18 ../
-r--r--r--  1 user  staff     4B  8 Feb 11:12 document.txt 

Server configuration

Operating system: Ubuntu 12.04 LTS

Web server: Apache2

Database: MySQL

PHP version: 5.4.x

ownCloud version: 6.0.4.1

Storage backend:

Client configuration

Client version: 2.1.0 (build 2944)

Operating system: OS X 10.11.2

OS language: English

Installation path of client: /Applications/ownCloud

Logs

Client log here:

https://gist.github.com/jrtilson/5f06e35994d7fdc63834

@jrtilson jrtilson changed the title Local files are read-only regardless of permissions on server [OS X][2.1.0] Local files are read-only regardless of permissions on server Feb 9, 2016
@jrtilson jrtilson changed the title [OS X][2.1.0] Local files are read-only regardless of permissions on server [OS X] [2.1.0] Local files are read-only regardless of permissions on server Feb 9, 2016
@guruz
Copy link
Contributor

guruz commented Feb 10, 2016

Could you please try 2.1.1 (rc2 or the release which comes today/tomorrow)

@jrtilson
Copy link
Author

I tried installing v 2.1.1, the issue persists on a fresh setup.

@jrtilson
Copy link
Author

Just an update/note: I tried a (very) old ownCloud client (v 1.5.0) and the files were read-write as was expected.

@guruz guruz added this to the 2.2-next milestone Feb 11, 2016
@marijnkortstra
Copy link

We're experiencing the exact same problem as @jrtilson.

@guruz
Copy link
Contributor

guruz commented Feb 14, 2016

@marijnkortstra Which version? Which OS? Did you try a clean re-sync?

@ckamm
Copy link
Contributor

ckamm commented Mar 1, 2016

The problem here is that remotePerm is "":

OCC::SyncJournalDb::setFileRecord: "INSERT OR REPLACE INTO metadata (phash, pathlen, path, inode, uid, gid, mode, modtime, type, md5, fileid, remotePerm, filesize, ignoredChildrenRemote, contentChecksum, contentChecksumTypeId) VALUES (?1 , ?2, ?3 , ?4 , ?5 , ?6 , ?7, ?8 , ?9 , ?10, ?11, ?12, ?13, ?14, ?15, ?16);" 5003461902563014693 30 "Shared/Technology/document.txt" 49081894 "1454947973" "0" "56b8be8e15f81" "00040118oc7449ebb679" "" 4 0 "" "" 0

So probably there's a bug in the version you use on the server (6.0.4.1). We should add a patch to not adjust permissions for servers this old.

@ckamm ckamm added type:bug and removed Needs info labels Mar 1, 2016
@guruz
Copy link
Contributor

guruz commented Mar 1, 2016

Server 6 is too old.

@marijnkortstra Which server version do you have?

@ckamm
Copy link
Contributor

ckamm commented Mar 1, 2016

@guruz Is server 6 among the versions we support with client 2.1?

@guruz
Copy link
Contributor

guruz commented Mar 1, 2016

@ckamm Versions 7 to 9 of the server are supported
https://github.com/owncloud/core/wiki/Maintenance-and-Release-Schedule

( @LukasReschke correct me if i'm wrong)

@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label Mar 1, 2016
@ckamm
Copy link
Contributor

ckamm commented Mar 1, 2016

The file permissions will now only be changed when the server version is 7.0.0 or newer.

@dragotin
Copy link
Contributor

dragotin commented Mar 1, 2016

@ckamm awesome

@ckamm
Copy link
Contributor

ckamm commented Mar 1, 2016

We talked about this on IRC and agreed we need to do something about unsupported server/client combinations. The discussion and plan is in #4523.

@ckamm
Copy link
Contributor

ckamm commented Mar 3, 2016

Closing this because the fix is small and we're not planning to actively support interaction with unsupported server versions anyway.

@ckamm ckamm closed this as completed Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyToTest QA, please validate the fix/enhancement type:bug
Projects
None yet
Development

No branches or pull requests

5 participants