Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace p12topem.* with QSslCertificate::importPkcs12 #5213

Closed
guruz opened this issue Sep 28, 2016 · 1 comment
Closed

Replace p12topem.* with QSslCertificate::importPkcs12 #5213

guruz opened this issue Sep 28, 2016 · 1 comment
Assignees
@guruz
Labels
technical debt
Milestone
2.3.0

Comments

@guruz
Copy link
Contributor

guruz commented Sep 28, 2016 •
edited
Loading

See https://code.woboq.org/qt5/qtbase/src/network/ssl/qsslcertificate.cpp.html#583

FYI @qknight @nocteau @Raptormagnum @jdhoek @dragotin

Any volunteers? I don't have a client cert setup.
Does anyone want to do this?
Or give me a cert/key and account?

This is to clean up for #69
@guruz guruz added this to the 2.3.0 milestone Sep 28, 2016
guruz added a commit that referenced this issue Oct 31, 2016
@guruz
WiP: Fix up SSL client certificates #5213 #69
f046cf3 
The re-enables the UI, uses Qt API for importing and
stores the certificate/key in the keychain.
guruz added a commit that referenced this issue Dec 5, 2016
@guruz
Fix up SSL client certificates #5213 #69
81631ee 
The re-enables the UI, uses Qt API for importing and
stores the certificate/key in the system keychain.
People who had set up client certs need to re-setup the account. This is ok
since it was an undocumented feature anyway.
@guruz
Copy link
Contributor Author

guruz commented Dec 5, 2016

Done in #5289
Please everyone review this PR

@guruz guruz closed this as completed Dec 5, 2016
guruz added a commit that referenced this issue Jan 2, 2017
@guruz
Fix up SSL client certificates #5213 #69 (#5289)
c6f4f44 
The re-enables the UI, uses Qt API for importing and
stores the certificate/key in the system keychain.
People who had set up client certs need to re-setup the account. This is ok
since it was an undocumented feature anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guruz guruz

Labels
technical debt
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@guruz