-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OS X > 10.10] ownCloud Extensions is running even when owncloud is not #5382
Comments
We don't control this, that process is only the sandbox shell for the plugin, and the plugin must be loaded by Finder in order for us to detect if the ownCloud client is reachable through the SocketAPI or not. This should normally match the behavior of Dropbox, Google Drive and other sync clients. Enabling or disabling the extension in "System Preferences / Extensions" is the normal way to let the user control the presence of this process, and activating/deactivating that setting on startup would mean that we overwrite what the user has chosen. It should however take no CPU, and very little memory. |
Dropbox seems to unload their extension, maybe it destroys itself? However they are allowed to do this since they install/uninstall the extension at runtime depending on a setting they have in the Dropbox settings. Not sure if we should go all that way to achieve this. I haven't checked what Google Drive does. |
@jturcotte thanks for explaining! I wanted to discuss a bit about this because I've found myself having an extension process from a client I had not opened for a while. And if somehow could we improve this so the process life span limits to the client's.
This is a really good point. We could consider how other projects deal with the sandboxed process for the finder sync extension and close if we don't find a better solution. |
@jturcotte Just tried:
And the sandboxed process is killed a bit after main process termination. It's also a child of |
@jturcotte maybe one additional reason to kill the finder extension process together with the client would be to allow users to uninstall from the apps folder; i.e right now you're prompted with: For the update process, I guess the |
@jturcotte Can't ownCloud client on exit send something to all connected sockets to make them unload themselves? |
The socket will be closed, so you can already know that in the plugin, the question is if you can exit the sandbox from the inside, or if you need to do this from the outside (like with some |
@jturcotte i think the |
Expected behaviour
When you close the sync client, the Extensions process helper should be closed too to avoid having resources consumed and files open. (owncloud should be the parent process)
Actual behaviour
The
ownCloud Extensions
process is created bylaunchd(1)
and keeps running indefinitely:Steps to reproduce
ownCloud Extensions
Client configuration
Client version: 2.2.4
Operating system: Mac OS X > 10.10 (Finder Sync Extension)
The text was updated successfully, but these errors were encountered: