Logged out accounts stay "Waiting" if unpaused #5477
Comments
|
What happens here is that whether a folder is paused and whether an account is logged in are orthogonal. When the account is logged out and you resume a folder, the folder gets queued. But it can't sync, so it just shows "Waiting...". We could adjust the text to say "Waiting for connectivity" or something. Would that make sense to you, @SamuAlfageme ? |
|
@ckamm hm, I was looking at this as a single state for the account (logged out) rather than 2 (logged out paused/unpaused) for the folder sync connection. But it makes sense to differentiate up to some point. The user might want to log in and start the sync/with it paused. We can settle with a label change to clarify; something like you suggest. |
Previously if you paused/unpaused a folder for a disconnected account they would prepare to sync and thus display the 'Waiting...' text. With this change, folders that can't possibly sync don't show text like this. When account connectivity changes, all unpaused folders will be scheduled anyway.
|
Trivial fix in https://github.com/ckamm/owncloud-client/tree/folder-ui-msg (I didn't change the message, but just treat these folders similar to paused folders, which removes the inconsistency) |
|
@SamuAlfageme Merged into 2.3 branch. |
|
Nice! 👍 |
Thought I had already reported this:
Expected behavior
It's not possible to click (i.e. button disabled) on resume either in the tray menu or the account view for any folder sync connection when the account is logged out.
Actual behavior
It's indeed possible and the account is "
Waiting...".Steps to reproduce
The text was updated successfully, but these errors were encountered: