-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save the new URL when hitting a permanent redirection 301 #5972
Comments
(I thought we did this, but maybe only in wizard.. FYI @ogoffart ) |
Since I'm set up for redirect testing anyway from #6003 I'll take care of this. I'll add redirection checking in the request for |
ckamm
added a commit
that referenced
this issue
Sep 11, 2017
This is the first time the account url may update outside of account setup. Summary of redirection handling: 1. During account setup (wizard) - status.php gets permanently redirected -> adjust url - authed PROPFIND gets *any* redirection -> adjust url 2. During connectivity ping (ConnectionValidator) - status.php gets permanently redirected -> adjust url (new!) All other redirections should be followed transparently and don't update the account url in the settings.
4 tasks
guruz
pushed a commit
that referenced
this issue
Sep 11, 2017
This is the first time the account url may update outside of account setup. Summary of redirection handling: 1. During account setup (wizard) - status.php gets permanently redirected -> adjust url - authed PROPFIND gets *any* redirection -> adjust url 2. During connectivity ping (ConnectionValidator) - status.php gets permanently redirected -> adjust url (new!) All other redirections should be followed transparently and don't update the account url in the settings.
thanks a ton @ckamm |
👍 yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behaviour
When you server URL is updated and your are redirected permanently (301) to a new URL, update the URL in the config.
Here: https://mycloud.example.org/owncloud -> https://mycloud.example.org/
Thunderbird lightning detects the redirect and asks if it should update the URL.
Actual behaviour
Follows the redirect but it means you have to keep the redirection forever
OC Client version 2.3.2
The text was updated successfully, but these errors were encountered: