Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the new URL when hitting a permanent redirection 301 #5972

Closed
tflidd opened this issue Aug 19, 2017 · 4 comments
Closed

Save the new URL when hitting a permanent redirection 301 #5972

tflidd opened this issue Aug 19, 2017 · 4 comments
Assignees
Labels
ReadyToTest QA, please validate the fix/enhancement
Milestone

Comments

@tflidd
Copy link

tflidd commented Aug 19, 2017

Expected behaviour

When you server URL is updated and your are redirected permanently (301) to a new URL, update the URL in the config.

Here: https://mycloud.example.org/owncloud -> https://mycloud.example.org/

Thunderbird lightning detects the redirect and asks if it should update the URL.

Actual behaviour

Follows the redirect but it means you have to keep the redirection forever

OC Client version 2.3.2

@guruz guruz changed the title Ask to update URL when hitting a permanent redirection 301 Save the new URL when hitting a permanent redirection 301 Aug 20, 2017
@guruz guruz added this to the 2.4.0 milestone Aug 20, 2017
@guruz
Copy link
Contributor

guruz commented Aug 25, 2017

(I thought we did this, but maybe only in wizard.. FYI @ogoffart )

@ckamm ckamm assigned ckamm and unassigned pmaier1 Sep 8, 2017
@ckamm
Copy link
Contributor

ckamm commented Sep 8, 2017

Since I'm set up for redirect testing anyway from #6003 I'll take care of this. I'll add redirection checking in the request for status.php. If we see a 301/308 there, it'll update the account with the new url.

ckamm added a commit that referenced this issue Sep 11, 2017
This is the first time the account url may update outside of
account setup.

Summary of redirection handling:
1. During account setup (wizard)
   - status.php gets permanently redirected -> adjust url
   - authed PROPFIND gets *any* redirection -> adjust url
2. During connectivity ping (ConnectionValidator)
   - status.php gets permanently redirected -> adjust url (new!)

All other redirections should be followed transparently and
don't update the account url in the settings.
guruz pushed a commit that referenced this issue Sep 11, 2017
This is the first time the account url may update outside of
account setup.

Summary of redirection handling:
1. During account setup (wizard)
   - status.php gets permanently redirected -> adjust url
   - authed PROPFIND gets *any* redirection -> adjust url
2. During connectivity ping (ConnectionValidator)
   - status.php gets permanently redirected -> adjust url (new!)

All other redirections should be followed transparently and
don't update the account url in the settings.
@guruz guruz added ReadyToTest QA, please validate the fix/enhancement Feature and removed Discussion labels Sep 11, 2017
@guruz
Copy link
Contributor

guruz commented Sep 11, 2017

thanks a ton @ckamm

@SamuAlfageme
Copy link
Contributor

👍 yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Development

No branches or pull requests

5 participants