-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context menu action to "open file in browser" to sync protocol and server activity #6121
Comments
To do this conveniently a bunch of functionality that's common to IssueWidget and ProtocolWidget is moved to ProtocolItem. Also the convenience function to asynchronously retrieve the private link url is moved from the socket api to the network jobs.
To do this conveniently a bunch of functionality that's common to IssueWidget and ProtocolWidget is moved to ProtocolItem. Also the convenience function to asynchronously retrieve the private link url is moved from the socket api to the network jobs.
To do this conveniently a bunch of functionality that's common to IssueWidget and ProtocolWidget is moved to ProtocolItem. Also the convenience function to asynchronously retrieve the private link url is moved from the socket api to the network jobs.
@ckamm we need to update https://github.com/owncloud/owncloud-client-binary right? |
Not yet, we'll need to do that when we're done with the shell integration additions of the same function for #5903 |
Works for me in protocol. |
It's about time to close this one as well 👍 this works great now. |
@guruz Improvement idea: I suggest to make both 'open in local file browser' and 'open in web browser' part of the right click context menu. Would be much clearer which is which. |
@jnweiger I agree with you about the graying out etc. Maybe create a new issue? |
@jnweiger That makes a lot of sense, I'll move it to an issue! |
Follow up from #5023.
What hasn't yet been implemented is to use private links to navigate from the sync protocol or server activity pane of the client to the web user interface.
Users should be able to right-click file entries in these views to get access to a "Open in browser" action.
There were also other tickets that suggested adding a context menu to the sync protocol view: #5982
The text was updated successfully, but these errors were encountered: