Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden folders/files are synced with 2.4.0 #6145

Closed
hodyroff opened this issue Nov 8, 2017 · 2 comments
Closed

Hidden folders/files are synced with 2.4.0 #6145

hodyroff opened this issue Nov 8, 2017 · 2 comments
Assignees
@ckamm
Labels
p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement sev2-high type:bug
Milestone
2.4.0

Comments

@hodyroff
Copy link

hodyroff commented Nov 8, 2017

Tested 2.4.0 Alpha1 with openSUSE Leap 42.2 against internal ownCloud Server with 10.0.3

Expected behaviour

Hidden files/folders shall not be synced, neither from the server to the client nor from the client to the server
Like with 2.3.x

Actual behaviour

Hidden files/folders started syncing from the server to the client.
Example: privat/.mozilla/plugins

Steps to reproduce

  1. Install 2.4.0 have hidden files/folders on the server side
  2. start sync
  3. files/folders appear
@hodyroff hodyroff added the p2-high Escalation, on top of current planning, release blocker label Nov 8, 2017
@ckamm ckamm added this to the 2.4.0 milestone Nov 8, 2017
@ckamm ckamm added the sev2-high label Nov 8, 2017
@ckamm ckamm self-assigned this Nov 8, 2017
@ckamm ckamm added the type:bug label Nov 8, 2017
@ckamm
Copy link
Contributor

ckamm commented Nov 8, 2017

Possibly related to the speedups in exclude detection @guruz

ckamm added a commit that referenced this issue Nov 8, 2017
@ckamm
Discovery: Treat files starting with '.' as hidden #6145
7effa9d 
This bug was introduced when strcmp(a, b) != 0 was accidentally
converted to a == b.
@ckamm ckamm mentioned this issue Nov 8, 2017
Merged
guruz pushed a commit that referenced this issue Nov 8, 2017
@ckamm @guruz
Discovery: Treat files starting with '.' as hidden #6145
37c5612 
This bug was introduced when strcmp(a, b) != 0 was accidentally
converted to a == b.
@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label Nov 8, 2017
@SamuAlfageme
Copy link
Contributor

Nice catch!

@ckamm thanks for including the csync test case 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckamm ckamm

Labels
p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement sev2-high type:bug
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
3 participants
@ckamm @hodyroff @SamuAlfageme