Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications] Open "link" in browser #6236

Closed
SamuAlfageme opened this issue Dec 12, 2017 · 4 comments
Closed

[Notifications] Open "link" in browser #6236

SamuAlfageme opened this issue Dec 12, 2017 · 4 comments
Assignees
Labels
Design & UX Discussion Enhancement ReadyToTest QA, please validate the fix/enhancement
Milestone

Comments

@SamuAlfageme
Copy link
Contributor

This is quite similar to the FR in #5922, this time about the "link" property of the notifications we get from the server. This got my eye on Marketplace notifications.

Tagging as discussion to see if this is something that would bring value to users. e.g. an admin clicking on a desktop notification to open an app's page in marketplace to update the version:

{
   "ocs":{
      "meta":{
         "status":"ok",
         "statuscode":200,
         "message":null,
         "totalitems":"",
         "itemsperpage":""
      },
      "data":[
         {
            "notification_id":1,
            "app":"market",
            "user":"admin",
            "datetime":"2017-12-12T07:54:04+00:00",
            "object_type":"market",
            "object_id":"0.2.3",
            "subject":"Update for Market to version 0.2.3 is available.",
            "message":"",
            "link":"<server>/apps/market/#/app/market",
            "actions":[],
            "icon":""
         }
      ]
   }
}

This one gets rendered as:

screenshot 2017-12-12 16 21 00

We could simply add a new button to open it in browser or make the whole thing clickable.

@guruz guruz added this to the 2.5.0 milestone Dec 13, 2017
dragotin added a commit that referenced this issue Dec 13, 2017
Added a new data called linkText. If the link in the activity JSON
has a space in it, the part before that is considered the link text.
If it does not contain a space, the word [link] is used.

This is maybe a solution for #6236
@dragotin dragotin self-assigned this Dec 13, 2017
dragotin added a commit that referenced this issue Feb 18, 2018
Added a new data called linkText. If the link in the activity JSON
has a space in it, the part before that is considered the link text.
If it does not contain a space, the word [link] is used.

This is maybe a solution for #6236
@guruz
Copy link
Contributor

guruz commented Apr 5, 2018

Indeed there is no link option from command line at least. I'll hack the source or so.

notifications:generate [-u|--user USER] [-g|--group GROUP] [--] <subject> [<message>]
..
sudo -u http ./occ notifications:generate -u guruz hello_subject "hello this is guruz speaking"

FYI @tomneedham

@guruz
Copy link
Contributor

guruz commented Apr 9, 2018

Indeed there is no link option from command line at least.

owncloud/notifications#172

@guruz
Copy link
Contributor

guruz commented Apr 13, 2018

-> #6453

@guruz guruz self-assigned this Apr 13, 2018
@ckamm ckamm added ReadyToTest QA, please validate the fix/enhancement and removed good first issue labels Apr 25, 2018
@ckamm
Copy link
Contributor

ckamm commented Apr 25, 2018

Tested manually on a oc-master instance by using the occ notifications:generate command.

@ckamm ckamm closed this as completed Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design & UX Discussion Enhancement ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Development

No branches or pull requests

4 participants