-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifications] Open "link" in browser #6236
Labels
Milestone
Comments
dragotin
added a commit
that referenced
this issue
Dec 13, 2017
Added a new data called linkText. If the link in the activity JSON has a space in it, the part before that is considered the link text. If it does not contain a space, the word [link] is used. This is maybe a solution for #6236
dragotin
added a commit
that referenced
this issue
Feb 18, 2018
Added a new data called linkText. If the link in the activity JSON has a space in it, the part before that is considered the link text. If it does not contain a space, the word [link] is used. This is maybe a solution for #6236
Indeed there is no link option from command line at least. I'll hack the source or so.
FYI @tomneedham |
|
guruz
added a commit
that referenced
this issue
Apr 13, 2018
-> #6453 |
guruz
added a commit
that referenced
this issue
Apr 17, 2018
ckamm
added
ReadyToTest
QA, please validate the fix/enhancement
and removed
good first issue
labels
Apr 25, 2018
Tested manually on a oc-master instance by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This is quite similar to the FR in #5922, this time about the "
link
" property of the notifications we get from the server. This got my eye on Marketplace notifications.Tagging as discussion to see if this is something that would bring value to users. e.g. an admin clicking on a desktop notification to open an app's page in marketplace to update the version:
This one gets rendered as:
We could simply add a new button to open it in browser or make the whole thing clickable.
The text was updated successfully, but these errors were encountered: