Taskbar indicator is green even when conflicts appear

[mueller-ma]

Expected behaviour

When the client cannot sync because of a conflict, the task bar icon should be the orange exclamation mark.

Actual behaviour

It has the green arrow.

Client configuration

Client version: 2.4.0

Operating system: Windows 7 64 bit

OS language: DE

[ckamm]

This used to be intentional. But I agree that it makes sense to indicate that user action is required to resolve conflicts in the icon. @SamuAlfageme

[SamuAlfageme]

@ckamm finally got to see this one working, nice!

Can we also extend the "info" status badge (i.e. https://github.com/owncloud/client/blob/master/theme/colored/state-information-256.png) to the folder sync connection for uniformity?

[SamuAlfageme]

I was also discussing "state indicators" coherence (e.g. if the client encountered errors, don't display the green badge...) with @michaelstingl last week and I need to review some behaviors for the multi-account and >1 local sync folder scenarios (i.e. multiple sources that need to be factored-out).

Bit offtopic: @ogoffart @guruz do you guys know any option for QSystemTrayIcons to display a really simple (green, yellow, red) individual status badge on each "Managed Folder". e.g. how Docker reports status on macOS:

[ckamm]

@SamuAlfageme The "green badge": that's simply an icon that was set for the menu item. We could definitely do that.

[ckamm]

@SamuAlfageme PR is available for the icon at #6438 if you want to test quickly.

[jnweiger]

OK: Taskbar icon has an exclamation mark, while there is a conflict: