setSelectiveSyncList is not transactional: selective sync entries lost in sqlite.db

[moscicki]

MacOSX, client 2.3.3 (and versions before)

This happens quite often when I have a disk full or on system shutdown.

Selective sync information is lost. It looks like this is not committed as a proper transaction. When this happens sync client complains about big folders and asks for action.

As a result I have to redefine and exclude from sync big folders manually every time (in the selective sync tree). This is very annoying and error prone.

Normally it looks like this:

sqlite3 ._sync_98ffb08a1b2e.db
SQLite version 3.8.5 2014-08-15 22:37:57
Enter ".help" for usage hints.
sqlite> select * from selectivesync;
Desktop/|2
Desktop/XYZ/|1
...

When the problem occurs it looks like this:

sqlite> select * from selectivesync;
Desktop/|1
...

@SamuAlfageme : you have seen this problem live at last workshop ;-)

[moscicki]

BTW: I won't be able to follow up on this for several days.

[ogoffart]

Right, SyncJournalDb::setSelectiveSyncList should be made more transactional.

[guruz]

@ogoffart setDataFingerprint too? Or change it to use INSERT OR REPLACE?

[ogoffart]

@guruz setDataFingerprint is already in a transaction because it is called from the sync engine in which everything is in a transaction.

[moscicki]

Question: can the loss of selective sync information also happen due to client shutdown while auto-update? We have such cases reported.

[ogoffart]

Not that i am aware of.

[ogoffart]

But the fix above was only done in 2.5.0, so upgrades to 2.4.x may still be affected by the original bug.

[moscicki]

It depends if the auto-update closes the sync client "gracefully" or not. I don't know how sparkle and msi do it.

…

On Tue, Oct 9, 2018 at 5:25 PM Olivier Goffart ***@***.***> wrote: But the fix above was only done in 2.5.0, so upgrades to 2.4.x may still be affected by the original bug. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6431 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAl9jbO-J8zztvZffojkhuKaOdFPBn8Fks5ujL_lgaJpZM4TJkOg> .

-- --- Best regards, Kuba