text on the gui becomes unreadable when connect failed

[jnweiger]

First screenshot below shows the next screen of the gui after entering login credentials.
If the credentiasl were invalid, and user presses the [Connect...] button, the screen changes to the second screenshot below.

Note the lines get squeezed to make room for the pink error message. Here everything is still readable, but sometimes one can no longer decipher the texts.

Seen on Kubuntu18.04 with Plasma desktop.

[ckamm]

@jnweiger I'll check it out and will be able to reproduce the label appearing -- but how did you get to this screen with invalid credentials? That shouldn't happen as far as I know!

[michaelstingl]

Server issue/hack is needed to get stuck with this error.

[guruz]

@jnweiger fix is in alpha, feel free to test and close

[SamuAlfageme]

Still reproducible in 2.5 (tested with a build based on 76bb76a):

Hints to reproduce:

• Set up mitmproxy on the client and set it to intercept all (.*) requests
• Get to the "Connect to ownCloud" page on the wizard and click connect
• Hit a to accept the request, then enter to inspect it
• Hit tab to switch to Response and e to edit, then o to tamper the HTTP code to e.g. 500
• Forward the response to the client (a to accept it)

[ckamm]

@SamuAlfageme Yes, this still happens for a multi-line error message, I had only tested with single-line errors.

The underlying problem is that this layout has no vertical wriggle room. So when an error message becomes visible and needs more space than expected there's not enough space left over all and the layout becomes squished. I'm checking whether I can give the middle spacer some shrinking flexibility.

[ckamm]

@SamuAlfageme There's a new PR to check out.

[jnweiger]

@michaelstingl @ckamm no server hackery needed. This was simply a client with preconfigured server url

[jnweiger]

reproduce attempt with #6589 results in a nice little scrollbar next to the error mssage, no more squeezed widgets.
Thanks!