Review wording with VFS

[jnweiger]

Seen with 2.6.0daily 20190313 on win10:

When VFS is enabled, and a new folder appears on the server, the client still says 'downloaded.'
that is misleading, if default is online only.

When I select 'Immer auf diesem Gerät behalten' the client pops up a notification with exactly the same wording.

Making the folder virtual again with 'Speicherplatz freigeben' the message is a vague 'updated':

[ckamm]

Indeed, I had updated the sync protocol entries in f786ef1 but haven't adjusted the notifications.

Now, what would be a good text for notifications though? Currently each action-kind in (new, deleted, updated, renamed, conflict, error) triggers a single notification that mentions the first such file by name. I wonder whether that's all that useful? But let's leave that for a different ticket.

For now I propose to adjust the wording for the "new" case to not say "downloaded". Continue to have "new-virtual" grouped with "new-regular". But put "newly-hydrated" into "updated", where "newly-dehydrated" already is.

[HanaGemela]

Adding a new virtual file says 'added'
Adding a new always downloaded file says 'added'
The above was done by adding a new file via the webUI

When I free up local space or make files always available locally, the message is still updated

[jnweiger]

'Immer auf diesem Gerät behalten' == 'Make alway available locally'
'Speicherplatz freigeben' == 'Free up local space'

Please do not invent new terms. I'd suggest to re-use the existing vocabulary as much as possible.
E.g. like this:

1. Server adds files, client "downloads" placeholders
   Notification "Foo.txt and 13 other files were added."
2. user changes to 'Make always available locally'
   Notification "Foo.txt and 13 other files are now always available locally."
3. user changes to 'Free up local space'
   Notification "Foo.txt and 13 others are now dehydrated."
   or
   Notification "Foo.txt and 13 others are now virtual."

We already have a redundancy of terms for e.g. hydrated=physical and dehydrated=virtual,
I personally would prefer the pair (physical/virtual) over (hydrated/dehydrated).

[ckamm]

@HanaGemela Your test confirms what I intended to do, see #7101 (comment). Thanks for moving further work on this to 2.6.1.

@jnweiger I agree. I've tried to keep "hydrated"/"dehydrated" (comes from cfapi) completely internal, users shouldn't see these terms. The reason cfapi introduced these is that there every file is a "placeholder" file, no matter whether hydrated or dehydrated.