Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pop-up windows with Dismiss buttons #7185

Closed
HanaGemela opened this issue May 13, 2019 · 1 comment
Closed

Pop-up windows with Dismiss buttons #7185

HanaGemela opened this issue May 13, 2019 · 1 comment
Assignees
@ogoffart
Labels
p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement type:bug
Milestone
2.6.0

Comments

@HanaGemela
Copy link
Contributor

Found on macOS 10.14.4
Client: 2.6.0-daily20190513 (build 11776)

Steps to recreate:

  1. Add 15 accounts (I've added once demo@demo.owncloud.com and 14x admin user connected to localhost)
  2. Upload 100MB file via web interface to localhost server (I don't think this step is necessary)
  3. Click on the account tabs in the client one by one
  4. Click on the Activity tab

Actual result: 6 times pop-up window with Dismiss button that cannot be clicked
Expected result: No pop-ups

image
@HanaGemela HanaGemela added this to the 2.6.0 milestone May 13, 2019
@ckamm ckamm added the p2-high Escalation, on top of current planning, release blocker label Jun 4, 2019
@ogoffart ogoffart self-assigned this Jun 4, 2019
ogoffart added a commit that referenced this issue Jun 4, 2019
@ogoffart
NotificationWidget: Fix buttons being leaked and show top level
42b5a6c 
Happens when the activity is updated

QDialogButtonBox::removeButton does not delete the button, it just reparent
it to nullptr.

Issue #7185
@ogoffart ogoffart mentioned this issue Jun 4, 2019
Merged
@ogoffart ogoffart added the ReadyToTest QA, please validate the fix/enhancement label Jun 4, 2019
guruz pushed a commit that referenced this issue Jun 4, 2019
@ogoffart @guruz
NotificationWidget: Fix buttons being leaked and show top level
eb20205 
Happens when the activity is updated

QDialogButtonBox::removeButton does not delete the button, it just reparent
it to nullptr.

Issue #7185
@HanaGemela
Copy link
Contributor Author

Cannot recreate in 2.6.0alpha2 (build 12128), macOS 10.14.5, believed to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogoffart ogoffart

Labels
p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement type:bug
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
3 participants
@ckamm @ogoffart @HanaGemela